Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 656303004: When QUIC sessions require confirmation from the server, allow either a (Closed)

Created:
6 years, 2 months ago by Ryan Hamilton
Modified:
6 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, quic-dev_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

When QUIC sessions require confirmation from the server, allow either a REJ or an SHLO to count. This should mean that anytime confirmation is required, the handshake should be at most 1 effective RTT whereas currently they can be 2 RTT. Committed: https://crrev.com/4b1a7934ae9813698cac812da634820ef86059d8 Cr-Commit-Position: refs/heads/master@{#300204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M net/quic/quic_client_session.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Ryan Hamilton
6 years, 2 months ago (2014-10-16 17:46:24 UTC) #2
ramant (doing other things)
lgtm
6 years, 2 months ago (2014-10-17 18:37:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656303004/1
6 years, 2 months ago (2014-10-17 18:39:54 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-18 00:41:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656303004/1
6 years, 2 months ago (2014-10-18 04:00:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-18 04:23:08 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-18 04:23:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b1a7934ae9813698cac812da634820ef86059d8
Cr-Commit-Position: refs/heads/master@{#300204}

Powered by Google App Engine
This is Rietveld 408576698