Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: content/browser/frame_host/render_frame_proxy_host.cc

Issue 656293005: Fix control message handling for RenderFrameProxyHost::Send. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_proxy_host.cc
diff --git a/content/browser/frame_host/render_frame_proxy_host.cc b/content/browser/frame_host/render_frame_proxy_host.cc
index 6f502f61e8bb006f4d2e2723b8700446367ce71a..be53fd18b7e6395801bcdc223c7f86ce06d87bcd 100644
--- a/content/browser/frame_host/render_frame_proxy_host.cc
+++ b/content/browser/frame_host/render_frame_proxy_host.cc
@@ -101,7 +101,10 @@ bool RenderFrameProxyHost::Send(IPC::Message *msg) {
// TODO(nasko): For now, RenderFrameHost uses this object to send IPC messages
// while swapped out. This can be removed once we don't have a swapped out
// state on RenderFrameHosts. See https://crbug.com/357747.
- msg->set_routing_id(routing_id_);
+
+ // Don't reset the routing ID for control messages. See crbug.com/423538
nasko 2014/10/16 18:09:32 nit: Being paranoid, I'd prefix the URL with https
+ if (msg->routing_id() != MSG_ROUTING_CONTROL)
+ msg->set_routing_id(routing_id_);
return GetProcess()->Send(msg);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698