Fix control message handling for RenderFrameProxyHost::Send.

Fix control message handling for RenderFrameProxyHost::Send.

When IPC messages are sent via RenderFrameProxyHost::Send, the message's routing ID is reset to the RFPH's routing ID before the message is actually sent.  This doesn't work for control messages, which are represented with a special routing ID.  As a result, control messages were routed incorrectly in the renderer when ChildThread::OnMessageReceived checked for (msg.routing_id() == MSG_ROUTING_CONTROL).  Currently, this only affects FrameMsg_NewFrameProxy, which is the only control message sent through RFPH.

BUG=423538
Committed: https://crrev.com/b8d6a8a0025ee6d1a54be617e31064597903eb5a
Cr-Commit-Position: refs/heads/master@{#300010}

[alexmos, 2014-10-16 17:23:54]

alexmos@chromium.org changed reviewers:
+ nasko@chromium.org

[alexmos, 2014-10-16 17:42:28]

Nasko, could you please review this fix as well?  

This needs to land after https://codereview.chromium.org/645363006/ to avoid a
CHECK for a duplicate RFP in RFP's constructor.

[nasko, 2014-10-16 18:09:32]

LGTM

https://codereview.chromium.org/656293005/diff/1/content/browser/frame_host/r...
File content/browser/frame_host/render_frame_proxy_host.cc (right):

https://codereview.chromium.org/656293005/diff/1/content/browser/frame_host/r...
content/browser/frame_host/render_frame_proxy_host.cc:105: // Don't reset the
routing ID for control messages.  See crbug.com/423538
nit: Being paranoid, I'd prefix the URL with https:// :)

[alexmos, 2014-10-16 18:48:41]

On 2014/10/16 18:09:32, nasko wrote:
> LGTM
> 
>
https://codereview.chromium.org/656293005/diff/1/content/browser/frame_host/r...
> File content/browser/frame_host/render_frame_proxy_host.cc (right):
> 
>
https://codereview.chromium.org/656293005/diff/1/content/browser/frame_host/r...
> content/browser/frame_host/render_frame_proxy_host.cc:105: // Don't reset the
> routing ID for control messages.  See crbug.com/423538
> nit: Being paranoid, I'd prefix the URL with https:// :)

Done. :)

[alexmos, 2014-10-16 22:46:17]

The CQ bit was checked by alexmos@chromium.org

[commit-bot: I haz the power, 2014-10-16 22:46:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/656293005/20001

[commit-bot: I haz the power, 2014-10-16 23:38:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-16 23:39:22]

Patchset 2 (id:??) landed as
https://crrev.com/b8d6a8a0025ee6d1a54be617e31064597903eb5a
Cr-Commit-Position: refs/heads/master@{#300010}