Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 656293003: [Mac] Do not initialize the MockCrApplication in base::TestSuite. (Closed)

Created:
6 years, 2 months ago by Robert Sesek
Modified:
6 years, 2 months ago
Reviewers:
Mark Mentovai, sky
CC:
chromium-reviews, peter+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mac] Do not initialize the MockCrApplication in base::TestSuite. This is not the right layer to do this, since it forces all test suites to have an initialized Cocoa NSApp. Instead, only do it for test suites that require it. BUG=71686 Committed: https://crrev.com/6a398155ce27db6153ca1c39eb6380d624fc8e01 Cr-Commit-Position: refs/heads/master@{#300275}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Ready for review #

Total comments: 3

Patch Set 4 : Invert negated conditions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -13 lines) Patch
M base/mac/scoped_sending_event_unittest.mm View 1 2 chunks +29 lines, -2 lines 0 comments Download
M base/test/test_suite.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/test/content_test_suite.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M ui/app_list/test/run_all_unittests.cc View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M ui/base/test/run_all_unittests.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/gfx/test/run_all_unittests.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/gfx/test/ui_cocoa_test_helper.mm View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M ui/message_center/test/run_all_unittests.cc View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Robert Sesek
6 years, 2 months ago (2014-10-17 18:40:05 UTC) #2
Mark Mentovai
LGTM https://codereview.chromium.org/656293003/diff/40001/base/mac/scoped_sending_event_unittest.mm File base/mac/scoped_sending_event_unittest.mm (right): https://codereview.chromium.org/656293003/diff/40001/base/mac/scoped_sending_event_unittest.mm#newcode11 base/mac/scoped_sending_event_unittest.mm:11: :) https://codereview.chromium.org/656293003/diff/40001/ui/app_list/test/run_all_unittests.cc File ui/app_list/test/run_all_unittests.cc (right): https://codereview.chromium.org/656293003/diff/40001/ui/app_list/test/run_all_unittests.cc#newcode15 ui/app_list/test/run_all_unittests.cc:15: #if ...
6 years, 2 months ago (2014-10-17 19:44:58 UTC) #3
Robert Sesek
+sky for //ui OWNERS https://codereview.chromium.org/656293003/diff/40001/ui/app_list/test/run_all_unittests.cc File ui/app_list/test/run_all_unittests.cc (right): https://codereview.chromium.org/656293003/diff/40001/ui/app_list/test/run_all_unittests.cc#newcode15 ui/app_list/test/run_all_unittests.cc:15: #if !defined(OS_MACOSX) On 2014/10/17 19:44:58, ...
6 years, 2 months ago (2014-10-17 21:02:29 UTC) #5
Robert Sesek
sky: ping
6 years, 2 months ago (2014-10-20 16:16:07 UTC) #6
sky
LGTM
6 years, 2 months ago (2014-10-20 16:16:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656293003/60001
6 years, 2 months ago (2014-10-20 16:17:10 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 2 months ago (2014-10-20 16:35:25 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 16:36:36 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6a398155ce27db6153ca1c39eb6380d624fc8e01
Cr-Commit-Position: refs/heads/master@{#300275}

Powered by Google App Engine
This is Rietveld 408576698