[session_manager] Move user session initialization code out of ExistingUserController

google_apis/gaia/gaia_auth_util.cc

Index: google_apis/gaia/gaia_auth_util.cc
diff --git a/google_apis/gaia/gaia_auth_util.cc b/google_apis/gaia/gaia_auth_util.cc
index eba0d7b6724b85b5ae24f7ef4dbbaec7ebf7b2f9..e30954ca71ec9ccca4e63c6a5ff10c052abb2e1a 100644
--- a/google_apis/gaia/gaia_auth_util.cc
+++ b/google_apis/gaia/gaia_auth_util.cc
@@ -25,8 +25,9 @@ std::string CanonicalizeEmailImpl(const std::string& email_address,
   char at = '@';
   base::SplitString(email_address, at, &parts);
   if (parts.size() != 2U) {
-    NOTREACHED() << "expecting exactly one @, but got " << parts.size()-1 <<
-        " : " << email_address;
+    NOTREACHED() << "expecting exactly one @, but got "
+                 << (parts.size() ? parts.size() - 1 : parts.size())

[Denis Kuznetsov (DE-MUC), 2014/10/20 13:38:59]

Use 0 in else-case (it look weird otherwise). And condition can use empty()
instead of size().

[Nikita (slow), 2014/10/20 13:52:11]

Done.

+                 << " : " << email_address;
   } else {
     if (change_googlemail_to_gmail && parts[1] == kGooglemailDomain)
       parts[1] = kGmailDomain;