Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 656263003: cc: Move GpuMemoryBufferManager interface to gpu namespace. (Closed)

Created:
6 years, 2 months ago by reveman
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, Ian Vollick, jam, yzshen+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, abarth-chromium, ben+mojo_chromium.org, danakj+watch_chromium.org, alexst (slow to review), boliu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Move GpuMemoryBufferManager interface to gpu namespace. This is necessary for in-process command buffer to be able to use this interface. BUG=423533 Committed: https://crrev.com/f9a8a234ccc2a487f49efd060cade85bc8c56cda Cr-Commit-Position: refs/heads/master@{#301662}

Patch Set 1 #

Patch Set 2 : deps fixes #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : add gpu dep to cc_test_support target #

Patch Set 6 : rebase #

Patch Set 7 : fix deps issue #

Patch Set 8 : remove mojo/ changes #

Patch Set 9 : include mojo/aura/surface_context_factory.* changes #

Patch Set 10 : mojo build fix #

Patch Set 11 : giving up trying to not add a .cc file #

Patch Set 12 : gn build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -101 lines) Patch
M cc/BUILD.gn View 1 3 chunks +2 lines, -1 line 0 comments Download
M cc/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M cc/cc.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M cc/cc_tests.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
D cc/resources/gpu_memory_buffer_manager.h View 1 2 3 4 5 1 chunk +0 lines, -34 lines 0 comments Download
M cc/resources/resource_provider.h View 1 2 3 4 5 6 6 chunks +5 lines, -5 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 2 3 4 5 6 4 chunks +3 lines, -3 lines 0 comments Download
M cc/surfaces/display.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cc/surfaces/display.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_tree_test.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/test_gpu_memory_buffer_manager.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 2 3 4 5 5 chunks +8 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 3 4 5 3 chunks +7 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/child_gpu_memory_buffer_manager.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/BUILD.gn View 1 2 3 4 5 11 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +11 lines, -0 lines 0 comments Download
A + gpu/command_buffer/client/gpu_memory_buffer_manager.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +10 lines, -8 lines 0 comments Download
A gpu/command_buffer/client/gpu_memory_buffer_manager.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +15 lines, -0 lines 0 comments Download
M gpu/command_buffer_client.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/aura/surface_context_factory.h View 1 2 3 4 5 6 8 1 chunk +1 line, -1 line 0 comments Download
M mojo/aura/surface_context_factory.cc View 1 2 3 4 5 6 8 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.cc View 8 9 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositor.h View 1 2 3 4 5 6 3 chunks +2 lines, -2 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 36 (15 generated)
reveman
6 years, 2 months ago (2014-10-17 14:30:00 UTC) #2
no sievers
lgtm
6 years, 2 months ago (2014-10-17 17:56:16 UTC) #3
reveman
+sky for mojo/
6 years, 2 months ago (2014-10-17 18:00:40 UTC) #5
sky
LGTM
6 years, 2 months ago (2014-10-20 16:06:58 UTC) #6
reveman
+enne for cc/
6 years, 2 months ago (2014-10-20 18:43:07 UTC) #8
enne (OOO)
Oops, sorry. cc lgtm!
6 years, 2 months ago (2014-10-21 22:10:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656263003/120001
6 years, 1 month ago (2014-10-28 01:02:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/20483)
6 years, 1 month ago (2014-10-28 01:17:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656263003/140001
6 years, 1 month ago (2014-10-28 03:11:34 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/12018)
6 years, 1 month ago (2014-10-28 03:30:14 UTC) #17
reveman
+jamesr for mojo/
6 years, 1 month ago (2014-10-28 03:56:08 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656263003/160001
6 years, 1 month ago (2014-10-28 03:56:58 UTC) #20
jamesr
lgtm
6 years, 1 month ago (2014-10-28 04:06:24 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/12027)
6 years, 1 month ago (2014-10-28 04:07:33 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656263003/180001
6 years, 1 month ago (2014-10-28 05:35:12 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg/builds/28887)
6 years, 1 month ago (2014-10-28 06:38:05 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656263003/200001
6 years, 1 month ago (2014-10-28 14:39:38 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/12036)
6 years, 1 month ago (2014-10-28 14:55:27 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656263003/220001
6 years, 1 month ago (2014-10-28 16:51:08 UTC) #34
commit-bot: I haz the power
Committed patchset #12 (id:220001)
6 years, 1 month ago (2014-10-28 17:55:12 UTC) #35
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 17:55:51 UTC) #36
Message was sent while issue was closed. 
Patchset 12 (id:??) landed as
https://crrev.com/f9a8a234ccc2a487f49efd060cade85bc8c56cda
Cr-Commit-Position: refs/heads/master@{#301662}

Powered by Google App Engine
This is Rietveld 408576698