Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 656223002: Use puts() instead of pluginLog() to avoid running JS during detach. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use puts() instead of pluginLog() to avoid running JS during detach. BUG=363099, 371084 Committed: https://crrev.com/eb036181ac1826a236c71226b071656d07b4ca7f Cr-Commit-Position: refs/heads/master@{#299860}

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/shell/tools/plugin/main.cpp View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dcheng
I think this should work... I don't have a non-Linux machine to test on at ...
6 years, 2 months ago (2014-10-16 05:19:50 UTC) #2
Mike West
On 2014/10/16 05:19:50, dcheng wrote: > I think this should work... I don't have a ...
6 years, 2 months ago (2014-10-16 05:51:05 UTC) #3
Mike West
On 2014/10/16 05:51:05, Mike West wrote: > On 2014/10/16 05:19:50, dcheng wrote: > > I ...
6 years, 2 months ago (2014-10-16 05:51:38 UTC) #4
dcheng
On 2014/10/16 at 05:51:38, mkwst wrote: > On 2014/10/16 05:51:05, Mike West wrote: > > ...
6 years, 2 months ago (2014-10-16 05:56:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656223002/20001
6 years, 2 months ago (2014-10-16 05:58:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-16 06:39:00 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 06:39:47 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb036181ac1826a236c71226b071656d07b4ca7f
Cr-Commit-Position: refs/heads/master@{#299860}

Powered by Google App Engine
This is Rietveld 408576698