Issue 6562: This fixes http://code.google.com/p/chromium/issues/detail?id=2472, which...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6562: This fixes http://code.google.com/p/chromium/issues/detail?id=2472, which... (Closed)

Created:
12 years, 2 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

This fixes http://code.google.com/p/chromium/issues/detail?id=2472, which is an issue with popups displayed by the flash plugin in response to a user click, getting blocked. The plugin invokes NPN_Evaluate to execute the javascript. It also invokes the NPN_PushPopupEnabledState/NPN_PopupEnabledState API's to set the popup enabled stack for the duration of the call. The fix is to add the plumbing in NPN_Evaluate to pass in a flag indicating whether popups are allowed for the duration of the call. Bug=2472 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3074

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -4 lines)			Patch
M	chrome/common/plugin_messages_internal.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/plugin/npobject_proxy.cc	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/plugin/npobject_stub.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/plugin/npobject_stub.cc	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	third_party/npapi/bindings/npruntime.h	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
M	webkit/port/bindings/v8/np_v8object.cpp	View	1 2	3 chunks	+22 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

12 years, 2 months ago (2008-10-08 00:05:46 UTC) #2

lgtm

http://codereview.chromium.org/6562/diff/15/16
File webkit/port/bindings/v8/np_v8object.cpp (right):

http://codereview.chromium.org/6562/diff/15/16#newcode297
Line 297: 
extra line

Expand Messages | Collapse Messages