Add MinidumpSimpleStringDictionaryWriter and its test

minidump/minidump_simple_string_dictionary_writer_test.cc

Index: minidump/minidump_simple_string_dictionary_writer_test.cc
diff --git a/minidump/minidump_simple_string_dictionary_writer_test.cc b/minidump/minidump_simple_string_dictionary_writer_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d5861ee1479e9c7bda0e3a9922e4175111f1b16a
--- /dev/null
+++ b/minidump/minidump_simple_string_dictionary_writer_test.cc
@@ -0,0 +1,206 @@
+// Copyright 2014 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "minidump/minidump_simple_string_dictionary_writer.h"
+
+#include <string>
+
+#include "gtest/gtest.h"
+#include "minidump/minidump_extensions.h"
+#include "util/file/string_file_writer.h"
+
+namespace crashpad {
+namespace test {
+namespace {
+
+const MinidumpSimpleStringDictionary* MinidumpSimpleStringDictionaryCast(
+    const StringFileWriter& file_writer) {
+  return reinterpret_cast<const MinidumpSimpleStringDictionary*>(
+      &file_writer.string()[0]);
+}
+
+TEST(MinidumpSimpleStringDictionaryWriter, EmptySimpleStringDictionary) {
+  StringFileWriter file_writer;
+
+  MinidumpSimpleStringDictionaryWriter dictionary_writer;
+
+  EXPECT_TRUE(dictionary_writer.WriteEverything(&file_writer));
+  ASSERT_EQ(sizeof(MinidumpSimpleStringDictionary),
+            file_writer.string().size());
+
+  const MinidumpSimpleStringDictionary* dictionary =
+      MinidumpSimpleStringDictionaryCast(file_writer);
+  EXPECT_EQ(0u, dictionary->count);
+}
+
+std::string MinidumpUTF8StringAtRVA(const StringFileWriter& file_writer,
+                                    RVA rva) {
+  if (rva == 0) {
+    return std::string();
+  }
+
+  const MinidumpUTF8String* minidump_string =
+      reinterpret_cast<const MinidumpUTF8String*>(&file_writer.string()[rva]);

[Robert Sesek, 2014/10/16 18:07:59]

Check if the rva is within bounds first? At the very least, add a warning
comment that caller must check that?

+  std::string minidump_string_data(
+      reinterpret_cast<const char*>(&minidump_string->Buffer[0]),
+      minidump_string->Length);
+  return minidump_string_data;
+}
+
+TEST(MinidumpSimpleStringDictionaryWriter, EmptyKeyValue) {
+  StringFileWriter file_writer;
+
+  MinidumpSimpleStringDictionaryWriter dictionary_writer;
+  MinidumpSimpleStringDictionaryEntryWriter entry_writer;
+  dictionary_writer.AddEntry(&entry_writer);
+
+  EXPECT_TRUE(dictionary_writer.WriteEverything(&file_writer));
+  ASSERT_EQ(sizeof(MinidumpSimpleStringDictionary) +
+                sizeof(MinidumpSimpleStringDictionaryEntry) +
+                2 * sizeof(MinidumpUTF8String) + 1 + 3 + 1,  // 3 for padding
+            file_writer.string().size());
+
+  const MinidumpSimpleStringDictionary* dictionary =
+      MinidumpSimpleStringDictionaryCast(file_writer);
+  EXPECT_EQ(1u, dictionary->count);
+  EXPECT_EQ(12u, dictionary->entries[0].key);
+  EXPECT_EQ(20u, dictionary->entries[0].value);
+  EXPECT_EQ("",
+            MinidumpUTF8StringAtRVA(file_writer, dictionary->entries[0].key));
+  EXPECT_EQ("",
+            MinidumpUTF8StringAtRVA(file_writer, dictionary->entries[0].value));
+}
+
+TEST(MinidumpSimpleStringDictionaryWriter, OneKeyValue) {
+  StringFileWriter file_writer;
+
+  char kKey[] = "key";
+  char kValue[] = "value";
+
+  MinidumpSimpleStringDictionaryWriter dictionary_writer;
+  MinidumpSimpleStringDictionaryEntryWriter entry_writer;
+  entry_writer.SetKeyValue(kKey, kValue);
+  dictionary_writer.AddEntry(&entry_writer);
+
+  EXPECT_TRUE(dictionary_writer.WriteEverything(&file_writer));
+  ASSERT_EQ(sizeof(MinidumpSimpleStringDictionary) +
+                sizeof(MinidumpSimpleStringDictionaryEntry) +
+                2 * sizeof(MinidumpUTF8String) + sizeof(kKey) + sizeof(kValue),
+            file_writer.string().size());
+
+  const MinidumpSimpleStringDictionary* dictionary =
+      MinidumpSimpleStringDictionaryCast(file_writer);
+  EXPECT_EQ(1u, dictionary->count);
+  EXPECT_EQ(12u, dictionary->entries[0].key);
+  EXPECT_EQ(20u, dictionary->entries[0].value);
+  EXPECT_EQ(kKey,
+            MinidumpUTF8StringAtRVA(file_writer, dictionary->entries[0].key));
+  EXPECT_EQ(kValue,
+            MinidumpUTF8StringAtRVA(file_writer, dictionary->entries[0].value));
+}
+
+TEST(MinidumpSimpleStringDictionaryWriter, ThreeKeysValues) {
+  StringFileWriter file_writer;
+
+  char kKey0[] = "mmm0";
+  char kValue0[] = "value0";
+  char kKey1[] = "zzz1";

[Robert Sesek, 2014/10/16 18:07:59]

These are all the same length. May be good to vary that.

+  char kValue1[] = "value1";
+  char kKey2[] = "aaa2";
+  char kValue2[] = "value2";
+
+  MinidumpSimpleStringDictionaryWriter dictionary_writer;
+  MinidumpSimpleStringDictionaryEntryWriter entry_writer_0;
+  entry_writer_0.SetKeyValue(kKey0, kValue0);
+  dictionary_writer.AddEntry(&entry_writer_0);
+  MinidumpSimpleStringDictionaryEntryWriter entry_writer_1;
+  entry_writer_1.SetKeyValue(kKey1, kValue1);
+  dictionary_writer.AddEntry(&entry_writer_1);
+  MinidumpSimpleStringDictionaryEntryWriter entry_writer_2;
+  entry_writer_2.SetKeyValue(kKey2, kValue2);
+  dictionary_writer.AddEntry(&entry_writer_2);
+
+  EXPECT_TRUE(dictionary_writer.WriteEverything(&file_writer));
+  ASSERT_EQ(sizeof(MinidumpSimpleStringDictionary) +
+                3 * sizeof(MinidumpSimpleStringDictionaryEntry) +
+                6 * sizeof(MinidumpUTF8String) + sizeof(kKey0) + 3 +
+                sizeof(kValue1) + 1 + sizeof(kKey1) + 3 + sizeof(kValue1) + 1 +
+                sizeof(kKey2) + 3 + sizeof(kValue2),
+            file_writer.string().size());
+
+  const MinidumpSimpleStringDictionary* dictionary =
+      MinidumpSimpleStringDictionaryCast(file_writer);
+  EXPECT_EQ(3u, dictionary->count);
+  EXPECT_EQ(28u, dictionary->entries[0].key);
+  EXPECT_EQ(40u, dictionary->entries[0].value);
+  EXPECT_EQ(52u, dictionary->entries[1].key);
+  EXPECT_EQ(64u, dictionary->entries[1].value);
+  EXPECT_EQ(76u, dictionary->entries[2].key);
+  EXPECT_EQ(88u, dictionary->entries[2].value);
+
+  // The entries don’t appear in the order they were added. The current
+  // implementation uses a std::map and sorts keys, so the entires appear in
+  // alphabetical order. However, this is an implementation detail, and it’s OK
+  // if the writer stops sorting in this order. Testing for a specific order is
+  // just the easiest way to write this test while the writer will output things
+  // in a known order.
+  EXPECT_EQ(kKey2,
+            MinidumpUTF8StringAtRVA(file_writer, dictionary->entries[0].key));
+  EXPECT_EQ(kValue2,
+            MinidumpUTF8StringAtRVA(file_writer, dictionary->entries[0].value));
+  EXPECT_EQ(kKey0,
+            MinidumpUTF8StringAtRVA(file_writer, dictionary->entries[1].key));
+  EXPECT_EQ(kValue0,
+            MinidumpUTF8StringAtRVA(file_writer, dictionary->entries[1].value));
+  EXPECT_EQ(kKey1,
+            MinidumpUTF8StringAtRVA(file_writer, dictionary->entries[2].key));
+  EXPECT_EQ(kValue1,
+            MinidumpUTF8StringAtRVA(file_writer, dictionary->entries[2].value));
+}
+
+TEST(MinidumpSimpleStringDictionaryWriter, DuplicateKeyValue) {
+  StringFileWriter file_writer;
+
+  char kKey[] = "key";
+  char kValue0[] = "fake_value";
+  char kValue1[] = "value";
+
+  MinidumpSimpleStringDictionaryWriter dictionary_writer;
+  MinidumpSimpleStringDictionaryEntryWriter entry_writer_0;
+  entry_writer_0.SetKeyValue(kKey, kValue0);
+  dictionary_writer.AddEntry(&entry_writer_0);
+  MinidumpSimpleStringDictionaryEntryWriter entry_writer_1;
+  entry_writer_1.SetKeyValue(kKey, kValue1);
+  dictionary_writer.AddEntry(&entry_writer_1);
+
+  EXPECT_TRUE(dictionary_writer.WriteEverything(&file_writer));
+  ASSERT_EQ(sizeof(MinidumpSimpleStringDictionary) +
+                sizeof(MinidumpSimpleStringDictionaryEntry) +
+                2 * sizeof(MinidumpUTF8String) + sizeof(kKey) + sizeof(kValue1),
+            file_writer.string().size());
+
+  const MinidumpSimpleStringDictionary* dictionary =
+      MinidumpSimpleStringDictionaryCast(file_writer);
+  EXPECT_EQ(1u, dictionary->count);
+  EXPECT_EQ(12u, dictionary->entries[0].key);
+  EXPECT_EQ(20u, dictionary->entries[0].value);
+  EXPECT_EQ(kKey,
+            MinidumpUTF8StringAtRVA(file_writer, dictionary->entries[0].key));
+  EXPECT_EQ(kValue1,
+            MinidumpUTF8StringAtRVA(file_writer, dictionary->entries[0].value));
+}
+
+}  // namespace
+}  // namespace test
+}  // namespace crashpad