Issue 656153002: Add a few missing dependencies of ChromeOS GN builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 656153002: Add a few missing dependencies of ChromeOS GN builds. (Closed)

Created:
6 years, 2 months ago by Jun Mukai

Modified:
6 years, 2 months ago

Reviewers:
oshima

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Add a few missing dependencies of ChromeOS GN builds. Otherwise component build causes linker errors. BUG=None R=oshima@chromium.org TEST=manually Committed: https://crrev.com/e87ec98e7dcd3ddefb1024cabae60ced4eda2cec Cr-Commit-Position: refs/heads/master@{#299947}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	ui/chromeos/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656153002/1

6 years, 2 months ago (2014-10-16 18:45:14 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-16 19:09:00 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e87ec98e7dcd3ddefb1024cabae60ced4eda2cec
Cr-Commit-Position: refs/heads/master@{#299947}