test/cctest/test-log-stack-tracer.cc - Issue 656143004: Remove (untested) code for unsupported compilers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-log-stack-tracer.cc

Issue 656143004: Remove (untested) code for unsupported compilers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix comment. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-log-stack-tracer.cc

diff --git a/test/cctest/test-log-stack-tracer.cc b/test/cctest/test-log-stack-tracer.cc

index 334a2010532bd3373b7547ede2ff4142ea7988e7..714ad69c8d7ecee8b8da094761c18f20962d4a71 100644

--- a/test/cctest/test-log-stack-tracer.cc

+++ b/test/cctest/test-log-stack-tracer.cc

@@ -235,9 +235,9 @@ TEST(PureJSStackTrace) {

static void CFuncDoTrace(byte dummy_parameter) {

Address fp;

-#ifdef __GNUC__

+#if V8_HAS_BUILTIN_FRAME_ADDRESS

fp = reinterpret_cast<Address>(__builtin_frame_address(0));

-#elif defined _MSC_VER

+#elif V8_CC_MSVC

// Approximate a frame pointer address. We compile without base pointers,

// so we can't trust ebp/rbp.

fp = &dummy_parameter - 2 * sizeof(void*); // NOLINT

« no previous file with comments | « test/cctest/cctest.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »