Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: test/cctest/test-log-stack-tracer.cc

Issue 656143004: Remove (untested) code for unsupported compilers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix comment. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/cctest.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 unsigned base = 0; 228 unsigned base = 0;
229 CHECK_GT(sample.frames_count, base + 1); 229 CHECK_GT(sample.frames_count, base + 1);
230 CHECK(IsAddressWithinFuncCode(context, "JSTrace", sample.stack[base + 0])); 230 CHECK(IsAddressWithinFuncCode(context, "JSTrace", sample.stack[base + 0]));
231 CHECK(IsAddressWithinFuncCode( 231 CHECK(IsAddressWithinFuncCode(
232 context, "OuterJSTrace", sample.stack[base + 1])); 232 context, "OuterJSTrace", sample.stack[base + 1]));
233 } 233 }
234 234
235 235
236 static void CFuncDoTrace(byte dummy_parameter) { 236 static void CFuncDoTrace(byte dummy_parameter) {
237 Address fp; 237 Address fp;
238 #ifdef __GNUC__ 238 #if V8_HAS_BUILTIN_FRAME_ADDRESS
239 fp = reinterpret_cast<Address>(__builtin_frame_address(0)); 239 fp = reinterpret_cast<Address>(__builtin_frame_address(0));
240 #elif defined _MSC_VER 240 #elif V8_CC_MSVC
241 // Approximate a frame pointer address. We compile without base pointers, 241 // Approximate a frame pointer address. We compile without base pointers,
242 // so we can't trust ebp/rbp. 242 // so we can't trust ebp/rbp.
243 fp = &dummy_parameter - 2 * sizeof(void*); // NOLINT 243 fp = &dummy_parameter - 2 * sizeof(void*); // NOLINT
244 #else 244 #else
245 #error Unexpected platform. 245 #error Unexpected platform.
246 #endif 246 #endif
247 i::TraceExtension::DoTrace(fp); 247 i::TraceExtension::DoTrace(fp);
248 } 248 }
249 249
250 250
(...skipping 26 matching lines...) Expand all
277 v8::Local<v8::Context> context = CcTest::NewContext(TRACE_EXTENSION); 277 v8::Local<v8::Context> context = CcTest::NewContext(TRACE_EXTENSION);
278 v8::Context::Scope context_scope(context); 278 v8::Context::Scope context_scope(context);
279 CHECK_EQ(0, i::TraceExtension::GetJsEntrySp()); 279 CHECK_EQ(0, i::TraceExtension::GetJsEntrySp());
280 CompileRun("a = 1; b = a + 1;"); 280 CompileRun("a = 1; b = a + 1;");
281 CHECK_EQ(0, i::TraceExtension::GetJsEntrySp()); 281 CHECK_EQ(0, i::TraceExtension::GetJsEntrySp());
282 CompileRun("js_entry_sp();"); 282 CompileRun("js_entry_sp();");
283 CHECK_EQ(0, i::TraceExtension::GetJsEntrySp()); 283 CHECK_EQ(0, i::TraceExtension::GetJsEntrySp());
284 CompileRun("js_entry_sp_level2();"); 284 CompileRun("js_entry_sp_level2();");
285 CHECK_EQ(0, i::TraceExtension::GetJsEntrySp()); 285 CHECK_EQ(0, i::TraceExtension::GetJsEntrySp());
286 } 286 }
OLDNEW
« no previous file with comments | « test/cctest/cctest.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698