Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 656143003: Ignore continuations when collapsing an anonymous block. (Closed)

Created:
6 years, 2 months ago by mstensho (USE GERRIT)
Modified:
6 years, 2 months ago
Reviewers:
pdr., aarya, inferno
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Ignore continuations when collapsing an anonymous block. When we decide to promote all children of an anonymous block and then nuke it, ignore any continuation set on the new parent of the children, to make sure that the children are in fact inserted as children of said new parent, and not somewhere else in the tree. This is a hack that's needed as long as we keep the old multicol implementation. The root cause is probably buggy block continuation handling, but fixing that would be risky. BUG=421720 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
A LayoutTests/fast/multicol/nested-multicol-two-spanners-dynamic.html View 1 chunk +37 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/nested-multicol-two-spanners-dynamic-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
mstensho (USE GERRIT)
6 years, 2 months ago (2014-10-15 18:41:57 UTC) #2
pdr.
+cc Abhishek, can you please review this?
6 years, 2 months ago (2014-10-15 22:56:44 UTC) #4
inferno
On 2014/10/15 22:56:44, pdr wrote: > +cc Abhishek, can you please review this? lgtm. but ...
6 years, 2 months ago (2014-10-16 06:34:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656143003/1
6 years, 2 months ago (2014-10-16 06:36:18 UTC) #7
mstensho (USE GERRIT)
On 2014/10/16 06:34:11, inferno wrote: > On 2014/10/15 22:56:44, pdr wrote: > > +cc Abhishek, ...
6 years, 2 months ago (2014-10-16 07:45:15 UTC) #9
aarya
On 2014/10/16 07:45:15, mstensho wrote: > On 2014/10/16 06:34:11, inferno wrote: > > On 2014/10/15 ...
6 years, 2 months ago (2014-10-16 15:37:21 UTC) #10
mstensho (USE GERRIT)
On 2014/10/16 15:37:21, aarya wrote: > On 2014/10/16 07:45:15, mstensho wrote: > > On 2014/10/16 ...
6 years, 2 months ago (2014-10-16 15:53:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656143003/1
6 years, 2 months ago (2014-10-16 15:54:19 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 15:55:25 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183823

Powered by Google App Engine
This is Rietveld 408576698