Issue 656143002: Const-correctness in PDF drawText() call

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 656143002: Const-correctness in PDF drawText() call (Closed)

Created:
6 years, 2 months ago by hal.canary

Modified:
6 years, 2 months ago

Reviewers:
bungeman-skia

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Const-correctness in PDF drawText() call If SkPDFDevice::drawText is called with glyph encoding and a font with cubic outlines (CFF or Type1) and a glyph code > 255 then it was mutating the in(const) glyph codes in place. Instead, a copy is made. BUG=skia:3019 Committed: https://skia.googlesource.com/skia/+/2f912f39b005b1725bd367c9dc5f1827cdde7be5

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	src/pdf/SkPDFDevice.cpp	View		1 chunk	+11 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hal.canary

`dm --pdf true --tests false --config pdf` seems to exercise this code.

6 years, 2 months ago (2014-10-16 16:35:01 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656143002/1

6 years, 2 months ago (2014-10-16 16:47:19 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-16 16:53:24 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 2f912f39b005b1725bd367c9dc5f1827cdde7be5

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages