Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 656123002: DevTools: [Console] select property names with double click (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 console.assert(propertyValue); 159 console.assert(propertyValue);
160 WebInspector.ObjectPropertyTreeElement.populate(this, propertyValue); 160 WebInspector.ObjectPropertyTreeElement.populate(this, propertyValue);
161 }, 161 },
162 162
163 /** 163 /**
164 * @override 164 * @override
165 * @return {boolean} 165 * @return {boolean}
166 */ 166 */
167 ondblclick: function(event) 167 ondblclick: function(event)
168 { 168 {
169 if (this.property.writable || this.property.setter) 169 if ((this.property.writable || this.property.setter) && event.target.isS elfOrDescendant(this.valueElement))
170 this.startEditing(event); 170 this.startEditing(event);
171 return false; 171 return false;
172 }, 172 },
173 173
174 /** 174 /**
175 * @override 175 * @override
176 */ 176 */
177 onattach: function() 177 onattach: function()
178 { 178 {
179 this.update(); 179 this.update();
(...skipping 892 matching lines...) Expand 10 before | Expand all | Expand 10 after
1072 { 1072 {
1073 WebInspector.TextPrompt.call(this, WebInspector.ExecutionContextSelector.com pletionsForTextPromptInCurrentContext); 1073 WebInspector.TextPrompt.call(this, WebInspector.ExecutionContextSelector.com pletionsForTextPromptInCurrentContext);
1074 this.setSuggestBoxEnabled(true); 1074 this.setSuggestBoxEnabled(true);
1075 if (renderAsBlock) 1075 if (renderAsBlock)
1076 this.renderAsBlock(); 1076 this.renderAsBlock();
1077 } 1077 }
1078 1078
1079 WebInspector.ObjectPropertyPrompt.prototype = { 1079 WebInspector.ObjectPropertyPrompt.prototype = {
1080 __proto__: WebInspector.TextPrompt.prototype 1080 __proto__: WebInspector.TextPrompt.prototype
1081 } 1081 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698