Refactor Script(Loader|Runner): don't access Resources all over the place...

Source/bindings/core/v8/ScriptStreamer.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ScriptStreamer_h
 #define ScriptStreamer_h
 
 #include "core/dom/PendingScript.h"
 #include "wtf/RefCounted.h"
 
@@ skipping 48 matching lines @@
     // we have the code cache for the script) and we still want to parse and
     // execute it when it has finished loading.
     void suppressStreaming();
     bool streamingSuppressed() const { return m_streamingSuppressed; }
 
     unsigned cachedDataType() const { return m_cachedDataType; }
 
     void addClient(ScriptResourceClient* client)
     {
         ASSERT(!m_client);
-        ASSERT(!isFinished());

[haraken, 2014/10/15 15:09:41]

Can we keep this ASSERT?

We want to avoid a situation where addClient is reentered.

[marja, 2014/10/16 15:19:03]

No, since ScriptLoader::prepareScript calls this for scripts which are already
finished and wants to get the notification immediately.

This is also consistent with Resource::addClient.

         m_client = client;
+        notifyFinishedToClient();
     }
 
     void removeClient(ScriptResourceClient* client)
     {
         ASSERT(m_client == client);
         m_client = 0;
     }
 
     // Called by PendingScript when data arrives from the network.
     void notifyAppendData(ScriptResource*);
@@ skipping 47 matching lines @@
     // What kind of cached data V8 produces during streaming.
     unsigned m_cachedDataType;
 
     // For recording metrics for different types of scripts separately.
     PendingScript::Type m_scriptType;
 };
 
 } // namespace blink
 
 #endif // ScriptStreamer_h