Issue 656103002: Add JSGraph::GetCachedNodes and NodeCache::GetCachedNodes. These routines are necessary in the dead…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 656103002: Add JSGraph::GetCachedNodes and NodeCache::GetCachedNodes. These routines are necessary in the dead… (Closed)

Created:
6 years, 2 months ago by titzer

Modified:
6 years, 2 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Add JSGraph::GetCachedNodes and NodeCache::GetCachedNodes. These routines are necessary in the dead code elimination phase to trim away uses from unreachable nodes. R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24632

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+272 lines, -9 lines)			Patch
M	src/compiler/common-node-cache.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/compiler/js-graph.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/compiler/js-graph.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/compiler/node-cache.h	View	2 chunks	+3 lines, -9 lines	1 comment	Download
M	src/compiler/node-cache.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	test/cctest/compiler/test-js-constant-cache.cc	View	3 chunks	+176 lines, -0 lines	0 comments	Download
M	test/cctest/compiler/test-node-cache.cc	View	1 chunk	+60 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

Urghs... LGTM with comment. https://codereview.chromium.org/656103002/diff/1/src/compiler/node-cache.h File src/compiler/node-cache.h (right): https://codereview.chromium.org/656103002/diff/1/src/compiler/node-cache.h#newcode10 src/compiler/node-cache.h:10: #include "src/compiler/node.h" Don't add the ...

6 years, 2 months ago (2014-10-15 12:06:39 UTC) #2

titzer

6 years, 2 months ago (2014-10-15 12:29:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 24632 (presubmit successful).

Expand Messages | Collapse Messages