Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 656083002: DevTools: remove test script-window-close-breakpoint.html (Closed)

Created:
6 years, 2 months ago by lushnikov
Modified:
6 years, 2 months ago
Reviewers:
aandrey, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: remove test script-window-close-breakpoint.html The patch kills invalid test script-window-close-breakpoint.html. The test itself expoits an old bug crbug.com/6773 and closes main window instead of a programmatically created one. This causes the layout test driver to crash on the following test as there's no window to navigate. BUG=423364 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -69 lines) Patch
M LayoutTests/FlakyTests View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/inspector-enabled/sources/debugger/script-window-close-breakpoint.html View 1 chunk +0 lines, -62 lines 0 comments Download
D LayoutTests/inspector-enabled/sources/debugger/script-window-close-breakpoint-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
lushnikov
6 years, 2 months ago (2014-10-15 11:09:51 UTC) #2
loislo
lgtm
6 years, 2 months ago (2014-10-15 11:11:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656083002/1
6 years, 2 months ago (2014-10-15 11:12:07 UTC) #5
aandrey
can we fix the test instead?
6 years, 2 months ago (2014-10-15 11:17:49 UTC) #7
lushnikov
On 2014/10/15 11:17:49, aandrey wrote: > can we fix the test instead? We've discussed this ...
6 years, 2 months ago (2014-10-15 11:30:00 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 13:05:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183747

Powered by Google App Engine
This is Rietveld 408576698