Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1888)

Unified Diff: Source/web/WebDocument.cpp

Issue 656073002: IDL: Use ALLOW_ONLY_INLINE_ALLOCATION() in dictionaries (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webmidi/MIDIOptions.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebDocument.cpp
diff --git a/Source/web/WebDocument.cpp b/Source/web/WebDocument.cpp
index d5cc1b13e5b84d82bdf21191c3b0ae85cdc08159..dc82bc51dc87a59460d99f0fc842c3993a32fdbb 100644
--- a/Source/web/WebDocument.cpp
+++ b/Source/web/WebDocument.cpp
@@ -331,8 +331,11 @@ v8::Handle<v8::Value> WebDocument::registerEmbedderCustomElement(const WebString
v8::Isolate* isolate = v8::Isolate::GetCurrent();
Document* document = unwrap<Document>();
TrackExceptionState exceptionState;
- ElementRegistrationOptions* registrationOptions = V8ElementRegistrationOptions::toImpl(isolate, options, exceptionState);
- ScriptValue constructor = document->registerElement(ScriptState::current(isolate), name, *registrationOptions, exceptionState, CustomElement::EmbedderNames);
+ ElementRegistrationOptions registrationOptions;
+ V8ElementRegistrationOptions::toImpl(isolate, options, registrationOptions, exceptionState);
+ if (exceptionState.hadException())
+ return v8::Handle<v8::Value>();
+ ScriptValue constructor = document->registerElement(ScriptState::current(isolate), name, registrationOptions, exceptionState, CustomElement::EmbedderNames);
ec = exceptionState.code();
if (exceptionState.hadException())
return v8::Handle<v8::Value>();
« no previous file with comments | « Source/modules/webmidi/MIDIOptions.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698