Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: Source/core/testing/DictionaryTest.cpp

Issue 656073002: IDL: Use ALLOW_ONLY_INLINE_ALLOCATION() in dictionaries (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/testing/DictionaryTest.h ('k') | Source/core/testing/InternalDictionary.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/testing/DictionaryTest.cpp
diff --git a/Source/core/testing/DictionaryTest.cpp b/Source/core/testing/DictionaryTest.cpp
index 90f8204beee7c88c7a93a2ceed067c3cfcdcf9ad..d1af7d1f05ab6467cc324ee1d329b2ad38a99ee2 100644
--- a/Source/core/testing/DictionaryTest.cpp
+++ b/Source/core/testing/DictionaryTest.cpp
@@ -50,36 +50,34 @@ void DictionaryTest::set(const InternalDictionary& testingDictionary)
m_objectOrNullMemberWithDefault = testingDictionary.objectOrNullMemberWithDefault();
}
-InternalDictionary* DictionaryTest::get()
+void DictionaryTest::get(InternalDictionary& result)
{
- InternalDictionary* result = InternalDictionary::create();
if (m_longMember)
- result->setLongMember(m_longMember.get());
- result->setLongMemberWithDefault(m_longMemberWithDefault);
+ result.setLongMember(m_longMember.get());
+ result.setLongMemberWithDefault(m_longMemberWithDefault);
if (m_longOrNullMember)
- result->setLongOrNullMember(m_longOrNullMember.get());
+ result.setLongOrNullMember(m_longOrNullMember.get());
if (m_longOrNullMemberWithDefault)
- result->setLongOrNullMemberWithDefault(m_longOrNullMemberWithDefault.get());
+ result.setLongOrNullMemberWithDefault(m_longOrNullMemberWithDefault.get());
if (m_booleanMember)
- result->setBooleanMember(m_booleanMember.get());
+ result.setBooleanMember(m_booleanMember.get());
if (m_doubleMember)
- result->setDoubleMember(m_doubleMember.get());
- result->setStringMember(m_stringMember);
- result->setStringMemberWithDefault(m_stringMemberWithDefault);
+ result.setDoubleMember(m_doubleMember.get());
+ result.setStringMember(m_stringMember);
+ result.setStringMemberWithDefault(m_stringMemberWithDefault);
if (m_stringSequenceMember)
- result->setStringSequenceMember(m_stringSequenceMember.get());
+ result.setStringSequenceMember(m_stringSequenceMember.get());
if (m_stringSequenceOrNullMember)
- result->setStringSequenceOrNullMember(m_stringSequenceOrNullMember.get());
- result->setEnumMember(m_enumMember);
- result->setEnumMemberWithDefault(m_enumMemberWithDefault);
- result->setEnumOrNullMember(m_enumOrNullMember);
+ result.setStringSequenceOrNullMember(m_stringSequenceOrNullMember.get());
+ result.setEnumMember(m_enumMember);
+ result.setEnumMemberWithDefault(m_enumMemberWithDefault);
+ result.setEnumOrNullMember(m_enumOrNullMember);
if (m_elementMember)
- result->setElementMember(m_elementMember);
+ result.setElementMember(m_elementMember);
if (m_elementOrNullMember)
- result->setElementOrNullMember(m_elementOrNullMember);
- result->setObjectMember(m_objectMember);
- result->setObjectOrNullMemberWithDefault(m_objectOrNullMemberWithDefault);
- return result;
+ result.setElementOrNullMember(m_elementOrNullMember);
+ result.setObjectMember(m_objectMember);
+ result.setObjectOrNullMemberWithDefault(m_objectOrNullMemberWithDefault);
}
void DictionaryTest::reset()
« no previous file with comments | « Source/core/testing/DictionaryTest.h ('k') | Source/core/testing/InternalDictionary.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698