IDL: Use ALLOW_ONLY_INLINE_ALLOCATION() in dictionaries

Source/bindings/scripts/v8_methods.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 161 matching lines @@
             if not argument.is_optional]),
         'only_exposed_to_private_script': is_only_exposed_to_private_script,
         'per_context_enabled_function': v8_utilities.per_context_enabled_function_name(method),  # [PerContextEnabled]
         'private_script_v8_value_to_local_cpp_value': idl_type.v8_value_to_local_cpp_value(
             extended_attributes, 'v8Value', 'cppValue', isolate='scriptState->isolate()', used_in_private_script=True),
         'property_attributes': property_attributes(method),
         'runtime_enabled_function': v8_utilities.runtime_enabled_function_name(method),  # [RuntimeEnabled]
         'should_be_exposed_to_script': not (is_implemented_in_private_script and is_only_exposed_to_private_script),
         'signature': 'v8::Local<v8::Signature>()' if is_static or 'DoNotCheckSignature' in extended_attributes else 'defaultSignature',
         'union_arguments': idl_type.union_arguments,
+        'use_argument_for_return_value': idl_type.is_dictionary,

[haraken, 2014/10/15 14:38:28]

use_output_parameter_for_result ?

'argument' is a bit confusing with a method argument.

'result' would be better for consistency with the following use_local_result.

[bashi, 2014/10/17 00:50:05]

Done.

         'use_local_result': use_local_result(method),
         'v8_set_return_value': v8_set_return_value(interface.name, method, this_cpp_value),
         'v8_set_return_value_for_main_world': v8_set_return_value(interface.name, method, this_cpp_value, for_main_world=True),
         'world_suffixes': ['', 'ForMainWorld'] if 'PerWorldBindings' in extended_attributes else [''],  # [PerWorldBindings],
     }
 
 
 def argument_context(interface, method, argument, index):
     extended_attributes = argument.extended_attributes
     idl_type = argument.idl_type
@@ skipping 67 matching lines @@
 
 ################################################################################
 # Value handling
 ################################################################################
 
 def cpp_value(interface, method, number_of_arguments):
     def cpp_argument(argument):
         idl_type = argument.idl_type
         if idl_type.name == 'EventListener':
             return argument.name
-        if idl_type.is_dictionary:
-            return '*%s' % argument.name
         if (idl_type.name in ['NodeFilter', 'NodeFilterOrNull',
                               'XPathNSResolver', 'XPathNSResolverOrNull']):
             # FIXME: remove this special case
             return '%s.release()' % argument.name
         return argument.name
 
     # Truncate omitted optional arguments
     arguments = method.arguments[:number_of_arguments]
     cpp_arguments = []
     if 'ImplementedInPrivateScript' in method.extended_attributes:
@@ skipping 21 matching lines @@
                               for member_argument in this_union_arguments])
 
     if 'ImplementedInPrivateScript' in method.extended_attributes:
         if method.idl_type.name != 'void':
             cpp_arguments.append('&result')
     elif ('RaisesException' in method.extended_attributes or
         (method.is_constructor and
          has_extended_attribute_value(interface, 'RaisesException', 'Constructor'))):
         cpp_arguments.append('exceptionState')
 
+    # If a method returns an IDL dictionary, the return value is passed
+    # as an argument to impl classes.
+    if method.idl_type and method.idl_type.is_dictionary:

[haraken, 2014/10/15 14:38:28]

Do we need the 'method.idl_type and' part?

[Jens Widell, 2014/10/15 15:39:17]

Probably for constructors. Typically when you think "when does a method ever not
have that?" around here the answer is "if it's actually a constructor." :-)

[bashi, 2014/10/17 00:50:05]

Yes. Similar check exists on L298.

+        cpp_arguments.append('cppValue')
+
     if method.name == 'Constructor':
         base_name = 'create'
     elif method.name == 'NamedConstructor':
         base_name = 'createForJSConstructor'
     elif 'ImplementedInPrivateScript' in method.extended_attributes:
         base_name = '%sMethod' % method.name
     else:
         base_name = v8_utilities.cpp_name(method)
 
     cpp_method_name = v8_utilities.scoped_name(interface, method, base_name)
@@ skipping 104 matching lines @@
 
 
 def union_arguments(idl_type):
     return [union_member_argument_context(member_idl_type, index)
             for index, member_idl_type
             in enumerate(idl_type.member_types)]
 
 
 def argument_default_cpp_value(argument):
     if argument.idl_type.is_dictionary:
-        # We always create impl objects for IDL dictionaries.
-        return '%s::create()' % argument.idl_type.base_type
+        return None
     if not argument.default_value:
         return None
     return argument.idl_type.literal_cpp_value(argument.default_value)
 
 IdlTypeBase.union_arguments = None
 IdlUnionType.union_arguments = property(union_arguments)
 IdlArgument.default_cpp_value = property(argument_default_cpp_value)
 
 
 def method_returns_promise(method):
     return method.idl_type and method.idl_type.name == 'Promise'
 
 IdlOperation.returns_promise = property(method_returns_promise)
 
 
 def argument_conversion_needs_exception_state(method, argument):
     idl_type = argument.idl_type
     return (idl_type.v8_conversion_needs_exception_state or
             argument.is_variadic or
             (method.returns_promise and (idl_type.is_string_type or
                                          idl_type.is_enum)))