Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: components/nacl_nonsfi.gyp

Issue 656063003: Non-SFI Mode: Build shared_memory_support_nacl library for nacl_helper_nonsfi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/media_nacl.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl_nonsfi.gyp
diff --git a/components/nacl_nonsfi.gyp b/components/nacl_nonsfi.gyp
index 2a06df0273e987511a4be0025a6140c930d92adc..63d233088bc262f2810de278962acedddbd1abdc 100644
--- a/components/nacl_nonsfi.gyp
+++ b/components/nacl_nonsfi.gyp
@@ -42,6 +42,7 @@
'extra_deps_newlib32_nonsfi': [
'>(tc_lib_dir_nonsfi_helper32)/libbase_nacl_nonsfi.a',
'>(tc_lib_dir_nonsfi_helper32)/libevent_nacl_nonsfi.a',
+ '>(tc_lib_dir_nonsfi_helper32)/libshared_memory_support_nacl.a',
],
}],
],
@@ -51,6 +52,11 @@
'../native_client/src/nonsfi/irt/irt.gyp:nacl_sys_private',
'../native_client/src/untrusted/nacl/nacl.gyp:nacl_lib_newlib',
'../native_client/tools.gyp:prep_toolchain',
+
+ # Temporarily depends on some libraries to make sure they can be
+ # built properly. These are depended by PPAPI library.
Mark Seaborn 2014/10/20 19:20:36 nit: "depended on by"
hidehiko 2014/10/21 05:11:34 Done.
+ # TODO(hidehiko): Remove them when PPAPI library is introduced.
+ '../media/media_nacl.gyp:shared_memory_support_nacl',
],
},
# TODO(hidehiko): Add Non-SFI version of nacl_loader_unittests.
« no previous file with comments | « no previous file | media/media_nacl.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698