Non-SFI Mode: Build shared_memory_support_nacl library for nacl_helper_nonsfi.

Non-SFI Mode: Build shared_memory_support_nacl library for nacl_helper_nonsfi.

This CL is to build the libshared_memory_support_nacl.a for nacl_helper_nonsfi.
The library is not used yet, but will be used soon in following CLs.
Also, it should be built successfully now.

BUG=358465
TEST=Ran trybots. Implement nacl_helper_nonsfi on top of this CL, and made sure it works.

Committed: https://crrev.com/0d20d8969982c6db6fef2680e3969b29e5b7036c
Cr-Commit-Position: refs/heads/master@{#300459}

[hidehiko, 2014-10-17 08:19:40]

hidehiko@chromium.org changed reviewers:
+ mseaborn@chromium.org, scherkus@chromium.org

[hidehiko, 2014-10-17 08:19:41]

mseaborn@, could you review from the project point of view?
scherkus@, could you review as an OWNER?

I'd appreciate your help,
- hidehiko

[Junichi Uekawa, 2014-10-17 10:24:20]

uekawa@chromium.org changed reviewers:
+ uekawa@chromium.org

[Junichi Uekawa, 2014-10-17 10:24:21]

https://codereview.chromium.org/656063003/diff/1/components/nacl_nonsfi.gyp
File components/nacl_nonsfi.gyp (right):

https://codereview.chromium.org/656063003/diff/1/components/nacl_nonsfi.gyp#n...
components/nacl_nonsfi.gyp:60:
'../media/media_nacl.gyp:shared_memory_support_nacl',
why not <(DEPTH) to be consistent ?

https://codereview.chromium.org/656063003/diff/1/media/media_nacl.gyp
File media/media_nacl.gyp (right):

https://codereview.chromium.org/656063003/diff/1/media/media_nacl.gyp#newcode44
media/media_nacl.gyp:44: ['disable_nacl_untrusted==0', {
the meat of change seems to be enabling nonsfi_helper even when
disable_nacl_untrusted = 1, is that really intentional ?

[hidehiko, 2014-10-20 06:28:18]

PTAL.

https://codereview.chromium.org/656063003/diff/1/components/nacl_nonsfi.gyp
File components/nacl_nonsfi.gyp (right):

https://codereview.chromium.org/656063003/diff/1/components/nacl_nonsfi.gyp#n...
components/nacl_nonsfi.gyp:60:
'../media/media_nacl.gyp:shared_memory_support_nacl',
On 2014/10/17 10:24:21, Junichi Uekawa wrote:
> why not <(DEPTH) to be consistent ?

Good point. Standardized with "../" instead of <(DEPTH).
cf):
https://groups.google.com/a/chromium.org/forum/m/#!topic/chromium-dev/y7IqhXy...

https://codereview.chromium.org/656063003/diff/1/media/media_nacl.gyp
File media/media_nacl.gyp (right):

https://codereview.chromium.org/656063003/diff/1/media/media_nacl.gyp#newcode44
media/media_nacl.gyp:44: ['disable_nacl_untrusted==0', {
On 2014/10/17 10:24:21, Junichi Uekawa wrote:
> the meat of change seems to be enabling nonsfi_helper even when
> disable_nacl_untrusted = 1, is that really intentional ?

Yes. We'll build nacl_helper_nonsfi regardless of disable_nacl_untrusted.

[Mark Seaborn, 2014-10-20 15:47:06]

https://codereview.chromium.org/656063003/diff/20001/media/media_nacl.gyp
File media/media_nacl.gyp (right):

https://codereview.chromium.org/656063003/diff/20001/media/media_nacl.gyp#new...
media/media_nacl.gyp:43: 'conditions': [
My comments from https://codereview.chromium.org/649183005/ apply here too. 
This pattern is complicated and I don't think it's good to be copying this into
every target that gets built for the IRT.

[hidehiko, 2014-10-20 17:53:51]

Patchset #4 (id:60001) has been deleted

[hidehiko, 2014-10-20 17:54:01]

Patchset #3 (id:40001) has been deleted

[hidehiko, 2014-10-20 19:01:52]

Thank you for review. PTAL.

https://codereview.chromium.org/656063003/diff/20001/media/media_nacl.gyp
File media/media_nacl.gyp (right):

https://codereview.chromium.org/656063003/diff/20001/media/media_nacl.gyp#new...
media/media_nacl.gyp:43: 'conditions': [
On 2014/10/20 15:47:06, Mark Seaborn wrote:
> My comments from https://codereview.chromium.org/649183005/ apply here too. 
> This pattern is complicated and I don't think it's good to be copying this
into
> every target that gets built for the IRT.

Done.

[Mark Seaborn, 2014-10-20 19:20:36]

LGTM

https://codereview.chromium.org/656063003/diff/80001/components/nacl_nonsfi.gyp
File components/nacl_nonsfi.gyp (right):

https://codereview.chromium.org/656063003/diff/80001/components/nacl_nonsfi.g...
components/nacl_nonsfi.gyp:57: # built properly. These are depended by PPAPI
library.
nit: "depended on by"

[scherkus (not reviewing), 2014-10-20 19:32:16]

media lgtm

[hidehiko, 2014-10-21 05:11:34]

Thank you for review. Submitting...

https://codereview.chromium.org/656063003/diff/80001/components/nacl_nonsfi.gyp
File components/nacl_nonsfi.gyp (right):

https://codereview.chromium.org/656063003/diff/80001/components/nacl_nonsfi.g...
components/nacl_nonsfi.gyp:57: # built properly. These are depended by PPAPI
library.
On 2014/10/20 19:20:36, Mark Seaborn wrote:
> nit: "depended on by"

Done.

[hidehiko, 2014-10-21 05:11:52]

The CQ bit was checked by hidehiko@chromium.org

[commit-bot: I haz the power, 2014-10-21 05:13:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/656063003/100001

[commit-bot: I haz the power, 2014-10-21 06:43:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-21 06:43:38]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hidehiko, 2014-10-21 10:49:32]

The CQ bit was checked by hidehiko@chromium.org

[commit-bot: I haz the power, 2014-10-21 10:53:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/656063003/100001

[commit-bot: I haz the power, 2014-10-21 11:33:03]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2014-10-21 11:33:49]

Patchset 4 (id:??) landed as
https://crrev.com/0d20d8969982c6db6fef2680e3969b29e5b7036c
Cr-Commit-Position: refs/heads/master@{#300459}