Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 656063002: Subresource Integrity: Improve parsing. (Closed)

Created:
6 years, 2 months ago by Mike West
Modified:
6 years, 2 months ago
Reviewers:
jww
CC:
blink-reviews, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Subresource Integrity: Improve parsing. This CL more or less rewrites the parser with the goal of improving our adherence to the spec. We now have reasonable error messages for parse failures, and have tests for the individual components of the parser (algorithms and digests). We also now correctly require 'ni:///' as the URL prefix (we were previously ignoring the last '/'). BUG=355467 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183788

Patch Set 1 #

Patch Set 2 : Oops. #

Patch Set 3 : #

Total comments: 10

Patch Set 4 : Feedback. #

Messages

Total messages: 7 (2 generated)
Mike West
Mind taking a look at this, Joel? Sorry, I should have caught most of this ...
6 years, 2 months ago (2014-10-15 09:53:19 UTC) #2
jww
LGTM, modulo a few minor comments. Thanks for tackling these fixes! https://codereview.chromium.org/656063002/diff/40001/Source/core/frame/SubresourceIntegrity.cpp File Source/core/frame/SubresourceIntegrity.cpp (right): ...
6 years, 2 months ago (2014-10-15 23:26:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656063002/60001
6 years, 2 months ago (2014-10-16 06:14:18 UTC) #5
Mike West
https://codereview.chromium.org/656063002/diff/40001/Source/core/frame/SubresourceIntegrity.cpp File Source/core/frame/SubresourceIntegrity.cpp (right): https://codereview.chromium.org/656063002/diff/40001/Source/core/frame/SubresourceIntegrity.cpp#newcode190 Source/core/frame/SubresourceIntegrity.cpp:190: // ni:///[algorithm];[hash] OR ni:///[algorithm];[hash]?[params] On 2014/10/15 23:26:04, jww wrote: ...
6 years, 2 months ago (2014-10-16 06:17:22 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 07:14:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 183788

Powered by Google App Engine
This is Rietveld 408576698