Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 656033010: CSS Tokenizer: Fix handling of escaped newlines (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
Reviewers:
Yoav Weiss
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

CSS Tokenizer: Fix handling of escaped newlines This patch fixes our handling of escaped newlines in the css-syntax tokenizer. Since we don't perform preprocessing, the logic is slightly trickier than in the spec. The preprocessing replaces \r, \r\n, \f with \n. Regarding escaped newlines in strings, the spec states: "Otherwise, if the next input code point is a newline, consume it." In this case, we may need to consume two tokens if we have \r\n. The other cases don't require special handling, since \r\n starts with \r (also a newline) and in these cases the following token is just going to be a whitespace token. BUG=424988 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M Source/core/css/parser/CSSTokenizer.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/core/css/parser/CSSTokenizerTest.cpp View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
6 years, 1 month ago (2014-10-24 07:01:13 UTC) #2
Yoav Weiss
On 2014/10/24 07:01:13, Timothy Loh wrote: LGTM
6 years, 1 month ago (2014-10-24 07:17:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656033010/1
6 years, 1 month ago (2014-10-24 09:25:38 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-24 11:14:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184347

Powered by Google App Engine
This is Rietveld 408576698