Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 656033009: Convert ARRAYSIZE_UNSAFE -> arraysize in base/. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org, Ilya Sherman, asvitkine+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Convert ARRAYSIZE_UNSAFE -> arraysize in base/. R=thestig@chromium.org BUG=423134 Committed: https://crrev.com/805eabb91d386c86bd64336c7643f6dfa864151d Cr-Commit-Position: refs/heads/master@{#299835}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -48 lines) Patch
M base/debug/proc_maps_linux_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/stack_trace_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/icu_string_conversions_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/i18n/number_formatting_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/i18n/rtl_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M base/json/string_escape_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M base/mac/mac_util_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/field_trial_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_number_conversions_unittest.cc View 14 chunks +14 lines, -14 lines 0 comments Download
M base/strings/string_split_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_util_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M base/strings/utf_offset_string_conversions_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/strings/utf_string_conversions_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/sync_socket_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/version_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 2 months ago (2014-10-16 01:55:46 UTC) #1
Lei Zhang
lgtm
6 years, 2 months ago (2014-10-16 02:02:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656033009/1
6 years, 2 months ago (2014-10-16 02:06:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 04:03:02 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 04:03:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/805eabb91d386c86bd64336c7643f6dfa864151d
Cr-Commit-Position: refs/heads/master@{#299835}

Powered by Google App Engine
This is Rietveld 408576698