components/domain_reliability/monitor_unittest.cc - Issue 656033008: Domain Reliability: Reenable AddBakedInConfigs test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/domain_reliability/monitor_unittest.cc

Issue 656033008: Domain Reliability: Reenable AddBakedInConfigs test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase; don't print all json file names Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/domain_reliability/monitor_unittest.cc

diff --git a/components/domain_reliability/monitor_unittest.cc b/components/domain_reliability/monitor_unittest.cc

index 392824a314a1342b3f875ba01a741d335be299d3..6dc8e015f7eec879f54abef9bccac526e348dd1f 100644

--- a/components/domain_reliability/monitor_unittest.cc

+++ b/components/domain_reliability/monitor_unittest.cc

@@ -258,7 +258,7 @@ TEST_F(DomainReliabilityMonitorTest, WasFetchedViaProxy) {

// Will fail when baked-in configs expire, as a reminder to update them.

// (Contact ttuttle@chromium.org if this starts failing.)

// Disabled due to expiration of redirector.gvt1.com. https://crbug.com/423590

davidben 2014/10/20 20:51:31 Nit: I'm guessing this comment should be removed.

Deprecated (see juliatuttle) 2014/10/20 21:07:47 Done.

-TEST_F(DomainReliabilityMonitorTest, DISABLED_AddBakedInConfigs) {

+TEST_F(DomainReliabilityMonitorTest, AddBakedInConfigs) {

// AddBakedInConfigs DCHECKs that the baked-in configs parse correctly, so

// this unittest will fail if someone tries to add an invalid config to the

// source tree.