Domain Reliability: Reenable AddBakedInConfigs test

Domain Reliability: Reenable AddBakedInConfigs test

Re-enable the disabled AddBakedInConfigs test after poking  bake_in_configs.py with a stick.

Also, tweak error handling in bake_in_configs.py so we print all failures (even JSON parse errors), not just the first one.

BUG=

Committed: https://crrev.com/6c3f81730d0cba1c2f16bbac0f011faee4381a2e
Cr-Commit-Position: refs/heads/master@{#300388}

[Deprecated (see juliatuttle), 2014-10-20 19:50:51]

ttuttle@chromium.org changed reviewers:
+ davidben@chromium.org

[Deprecated (see juliatuttle), 2014-10-20 19:50:51]

ttuttle@chromium.org changed required reviewers:
+ davidben@chromium.org

[Deprecated (see juliatuttle), 2014-10-20 19:50:52]

PTAL, davidben.

[davidben, 2014-10-20 20:51:32]

https://codereview.chromium.org/656033008/diff/40001/components/domain_reliab...
File components/domain_reliability/bake_in_configs.py (right):

https://codereview.chromium.org/656033008/diff/40001/components/domain_reliab...
components/domain_reliability/bake_in_configs.py:539: continue
Nit: could you add a sentence about this in the CL description? It doesn't seem
related to re-enabling it. (I suppose it could also be split out, but whatever.)

https://codereview.chromium.org/656033008/diff/40001/components/domain_reliab...
components/domain_reliability/bake_in_configs.py:556: return 1
Does the build still fail if this happens? It seems we shouldn't have the build
continue with invalid files. Or is the intent here just so you get all the
errors in one go?

https://codereview.chromium.org/656033008/diff/40001/components/domain_reliab...
File components/domain_reliability/monitor_unittest.cc (right):

https://codereview.chromium.org/656033008/diff/40001/components/domain_reliab...
components/domain_reliability/monitor_unittest.cc:260: // Disabled due to
expiration of redirector.gvt1.com.  https://crbug.com/423590
Nit: I'm guessing this comment should be removed.

[Deprecated (see juliatuttle), 2014-10-20 21:07:47]

PTAL, davidben.

https://codereview.chromium.org/656033008/diff/40001/components/domain_reliab...
File components/domain_reliability/bake_in_configs.py (right):

https://codereview.chromium.org/656033008/diff/40001/components/domain_reliab...
components/domain_reliability/bake_in_configs.py:539: continue
On 2014/10/20 20:51:31, David Benjamin wrote:
> Nit: could you add a sentence about this in the CL description? It doesn't
seem
> related to re-enabling it. (I suppose it could also be split out, but
whatever.)

Done.

https://codereview.chromium.org/656033008/diff/40001/components/domain_reliab...
components/domain_reliability/bake_in_configs.py:556: return 1
On 2014/10/20 20:51:31, David Benjamin wrote:
> Does the build still fail if this happens? It seems we shouldn't have the
build
> continue with invalid files. Or is the intent here just so you get all the
> errors in one go?

Yes, this is main, and it's wrapped in sys.exit below, so it will fail if any
files were invalid, but it makes sure it prints *all* the failures, not just the
first one.

https://codereview.chromium.org/656033008/diff/40001/components/domain_reliab...
File components/domain_reliability/monitor_unittest.cc (right):

https://codereview.chromium.org/656033008/diff/40001/components/domain_reliab...
components/domain_reliability/monitor_unittest.cc:260: // Disabled due to
expiration of redirector.gvt1.com.  https://crbug.com/423590
On 2014/10/20 20:51:31, David Benjamin wrote:
> Nit: I'm guessing this comment should be removed.

Done.

[davidben, 2014-10-20 22:17:39]

lgtm

[Deprecated (see juliatuttle), 2014-10-20 23:19:10]

The CQ bit was checked by ttuttle@chromium.org

[commit-bot: I haz the power, 2014-10-20 23:21:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/656033008/60001

[commit-bot: I haz the power, 2014-10-21 00:32:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-21 00:33:15]

Patchset 4 (id:??) landed as
https://crrev.com/6c3f81730d0cba1c2f16bbac0f011faee4381a2e
Cr-Commit-Position: refs/heads/master@{#300388}