Fix crash with --use-gl=egl on Linux.

content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/sandbox_linux/sandbox_seccomp_bpf_linux.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <sys/socket.h>
 #include <sys/stat.h>
@@ skipping 16 matching lines @@
 #include "content/common/sandbox_linux/bpf_utility_policy_linux.h"
 #include "content/common/sandbox_linux/sandbox_bpf_base_policy_linux.h"
 #include "content/common/sandbox_linux/sandbox_linux.h"
 #include "sandbox/linux/seccomp-bpf-helpers/baseline_policy.h"
 #include "sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.h"
 #include "sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.h"
 #include "sandbox/linux/seccomp-bpf-helpers/syscall_sets.h"
 #include "sandbox/linux/seccomp-bpf/sandbox_bpf.h"
 #include "sandbox/linux/services/linux_syscalls.h"
 
+#if !defined(IN_NACL_HELPER)
+#include "ui/gl/gl_switches.h"
+#endif
+
 using sandbox::BaselinePolicy;
 using sandbox::SandboxBPF;
 using sandbox::SyscallSets;
 using sandbox::bpf_dsl::Allow;
 using sandbox::bpf_dsl::ResultExpr;
 
 #else
 
 // Make sure that seccomp-bpf does not get disabled by mistake. Also make sure
 // that we think twice about this when adding a new architecture.
@@ skipping 100 matching lines @@
   // the object to be destroyed after the sandbox has been started. Note that
   // doing so does not stop the sandbox.
   SandboxBPF sandbox;
   sandbox.SetSandboxPolicy(policy);
   CHECK(sandbox.StartSandbox(SandboxBPF::PROCESS_SINGLE_THREADED));
 }
 
 // nacl_helper needs to be tiny and includes only part of content/
 // in its dependencies. Make sure to not link things that are not needed.
 #if !defined(IN_NACL_HELPER)
+class GpuEGLProcessPolicy : public GpuProcessPolicy {

[jln (very slow on Chromium), 2014/10/17 18:13:38]

Why make it a new class? If you really need this, please make it a parameter of
an existing class instead. See allow_sysv_shm for an example.

+ public:
+  GpuEGLProcessPolicy() { }
+  virtual ~GpuEGLProcessPolicy() {}
+
+  virtual ResultExpr EvaluateSyscall(
+      int sysno) const override;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(GpuEGLProcessPolicy);
+};
+
+ResultExpr GpuEGLProcessPolicy::EvaluateSyscall(int sysno) const {
+  switch (sysno) {
+    // eglCreateWindowSurface() needs mincore().
+    case __NR_mincore:
+      return Allow();
+    default:
+      return GpuProcessPolicy::EvaluateSyscall(sysno);
+  }
+}
+
 scoped_ptr<SandboxBPFBasePolicy> GetGpuProcessSandbox() {
   const base::CommandLine& command_line =
       *base::CommandLine::ForCurrentProcess();
   bool allow_sysv_shm = false;
   if (command_line.HasSwitch(switches::kGpuSandboxAllowSysVShm)) {
     DCHECK(IsArchitectureArm());
     allow_sysv_shm = true;
   }
 
   if (IsChromeOS() && IsArchitectureArm()) {
     return scoped_ptr<SandboxBPFBasePolicy>(
         new CrosArmGpuProcessPolicy(allow_sysv_shm));
   } else {
-    return scoped_ptr<SandboxBPFBasePolicy>(new GpuProcessPolicy);
+    if (command_line.HasSwitch(switches::kUseGL) &&
+        command_line.GetSwitchValueASCII(switches::kUseGL) ==
+            gfx::kGLImplementationEGLName) {
+      return scoped_ptr<SandboxBPFBasePolicy>(new GpuEGLProcessPolicy);
+    } else {
+      return scoped_ptr<SandboxBPFBasePolicy>(new GpuProcessPolicy);
+    }
   }
 }
 
 // Initialize the seccomp-bpf sandbox.
 bool StartBPFSandbox(const base::CommandLine& command_line,
                      const std::string& process_type) {
   scoped_ptr<SandboxBPFBasePolicy> policy;
 
   if (process_type == switches::kGpuProcess) {
     policy.reset(GetGpuProcessSandbox().release());
@@ skipping 105 matching lines @@
 scoped_ptr<sandbox::bpf_dsl::SandboxBPFDSLPolicy>
 SandboxSeccompBPF::GetBaselinePolicy() {
 #if defined(USE_SECCOMP_BPF)
   return scoped_ptr<sandbox::bpf_dsl::SandboxBPFDSLPolicy>(new BaselinePolicy);
 #else
   return scoped_ptr<sandbox::bpf_dsl::SandboxBPFDSLPolicy>();
 #endif  // defined(USE_SECCOMP_BPF)
 }
 
 }  // namespace content