Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 655963005: Fix About link for RTL (Closed)

Created:
6 years, 2 months ago by michaelpg
Modified:
6 years, 2 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix About link for RTL I realized I used margin-right instead of the direction-neutral -webkit-margin-end in the M40 fix, so the margin between the About link and the search box will be too small in RTL. This fix is already included in the M38 CL. BUG=421236 R=stevenjb@chromium.org Committed: https://crrev.com/0ec2d447ad4ce8e14e4ba0f60e40a1f193b6ef98 Cr-Commit-Position: refs/heads/master@{#300517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/options/browser_options.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
michaelpg
Tiny fix
6 years, 2 months ago (2014-10-21 01:39:58 UTC) #1
stevenjb
lgtm
6 years, 2 months ago (2014-10-21 15:34:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655963005/1
6 years, 2 months ago (2014-10-21 16:46:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 17:49:15 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 17:50:59 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ec2d447ad4ce8e14e4ba0f60e40a1f193b6ef98
Cr-Commit-Position: refs/heads/master@{#300517}

Powered by Google App Engine
This is Rietveld 408576698