Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 655963002: gpu: Fix webview parent compositor crash in context loss (Closed)

Created:
6 years, 2 months ago by boliu
Modified:
6 years, 2 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gpu: Fix webview parent compositor crash in context loss Android WebView parent compositor runs a thread without an message loop, ie MessageLoop[Proxy]::current returns null. This means any WrapCallback will crash immediately when called. This is a hack-ish fix to just check for this case and call through immediately, as the client thread and the gpu thread will be the same. BUG= Committed: https://crrev.com/afd978c6880d94df9cd488c2e78c4bff7b9de58f Cr-Commit-Position: refs/heads/master@{#299742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
boliu
PTAL
6 years, 2 months ago (2014-10-15 00:05:09 UTC) #2
no sievers
lgtm
6 years, 2 months ago (2014-10-15 18:04:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655963002/1
6 years, 2 months ago (2014-10-15 18:07:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 19:32:04 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 19:32:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afd978c6880d94df9cd488c2e78c4bff7b9de58f
Cr-Commit-Position: refs/heads/master@{#299742}

Powered by Google App Engine
This is Rietveld 408576698