Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 655843004: Revert of Add src-side launcher for telemetry_unittests (Closed)

Created:
6 years, 2 months ago by jam
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Add src-side launcher for telemetry_unittests (patchset #7 id:120001 of https://codereview.chromium.org/649683005/) Reason for revert: windows trybots broken please be around after landing changes and verify that bots are working Original issue's description: > Add src-side launcher for telemetry_unittests > > This will need a recipe-side change to pass the paths known to recipe > (from the path recipe module) and properties (from the properties > recipe module). > > Each of these key-value pairs is passed as two command line arguments, > so that parsing them is easy and rock solid (avoids escaping issues), > and is also easy to convert to dict python-side. > > BUG=422235 > R=iannucci@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/5316422143176a4a6457ce173ec9597a2e0eda69 TBR=iannucci@chromium.org,phajdan.jr@chromium.org NOTREECHECKS=true NOTRY=true BUG=422235 Committed: https://crrev.com/18b0c3bbb6a6a64236dc3bd162f9f77b7d9387a2 Cr-Commit-Position: refs/heads/master@{#300687}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -250 lines) Patch
M testing/scripts/checkdeps.py View 2 chunks +45 lines, -16 lines 0 comments Download
D testing/scripts/common.py View 1 chunk +0 lines, -117 lines 0 comments Download
D testing/scripts/get_compile_targets.py View 1 chunk +0 lines, -55 lines 0 comments Download
D testing/scripts/telemetry_unittests.py View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jam
Created Revert of Add src-side launcher for telemetry_unittests
6 years, 2 months ago (2014-10-22 16:29:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655843004/1
6 years, 2 months ago (2014-10-22 16:30:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655843004/1
6 years, 2 months ago (2014-10-22 16:36:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 16:38:32 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 16:39:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18b0c3bbb6a6a64236dc3bd162f9f77b7d9387a2
Cr-Commit-Position: refs/heads/master@{#300687}

Powered by Google App Engine
This is Rietveld 408576698