Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 655823005: Specifies transparent background for the label in TileItemView. (Closed)

Created:
6 years, 2 months ago by Jun Mukai
Modified:
6 years, 2 months ago
Reviewers:
xiyuan, calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, tapted, calamity
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Specifies transparent background for the label in TileItemView. We may not use single background when it's in Athena (it's not used yet though). BUG=425717 R=xiyuan@chromium.org TEST=manually Committed: https://crrev.com/3b74c2c950e3681a94601f61d48a6ff0e25f06f8 Cr-Commit-Position: refs/heads/master@{#301007}

Patch Set 1 #

Patch Set 2 : ifdef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M ui/app_list/views/tile_item_view.cc View 1 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 10 (1 generated)
Jun Mukai
6 years, 2 months ago (2014-10-23 18:33:24 UTC) #1
xiyuan
+calamity Font with transparent background does not render well on Windows. This CL might regress ...
6 years, 2 months ago (2014-10-23 19:16:16 UTC) #2
Jun Mukai
On 2014/10/23 19:16:16, xiyuan wrote: > +calamity > > Font with transparent background does not ...
6 years, 2 months ago (2014-10-23 20:58:40 UTC) #3
xiyuan
lgtm
6 years, 2 months ago (2014-10-23 21:03:16 UTC) #4
calamity
lgtm, nice catch
6 years, 2 months ago (2014-10-23 23:26:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655823005/10002
6 years, 2 months ago (2014-10-23 23:35:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:10002)
6 years, 2 months ago (2014-10-24 00:46:20 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3b74c2c950e3681a94601f61d48a6ff0e25f06f8 Cr-Commit-Position: refs/heads/master@{#301007}
6 years, 2 months ago (2014-10-24 00:47:00 UTC) #9
kjellander_chromium
6 years, 2 months ago (2014-10-24 06:16:07 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:10002) has been created in
https://codereview.chromium.org/674083002/ by kjellander@chromium.org.

The reason for reverting is: Introduces static initializer, see
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/72389.

Powered by Google App Engine
This is Rietveld 408576698