android_webview/native/aw_contents.h - Issue 655813004: Part 1: Refactor Android WebView graphics code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents.h

Issue 655813004: Part 1: Refactor Android WebView graphics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor

Patch Set: comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/aw_contents.h

diff --git a/android_webview/native/aw_contents.h b/android_webview/native/aw_contents.h

index f350b734c4d238ad3c01624a3bc0cf0bbddac0d5..7ada4368fa2341d5a631578792a1e7d1c1f5c280 100644

--- a/android_webview/native/aw_contents.h

+++ b/android_webview/native/aw_contents.h

@@ -239,8 +239,12 @@ class AwContents : public FindHelper::Listener,

scoped_ptr<FindHelper> find_helper_;

scoped_ptr<IconHelper> icon_helper_;

scoped_ptr<AwContents> pending_contents_;

- SharedRendererState shared_renderer_state_;

BrowserViewRenderer browser_view_renderer_;

+ // SharedRendererState is owned by BrowserViewRenderer.

+ // So keep a raw pointer here.

+ SharedRendererState* shared_renderer_state_;

+ // TODO(hush): hardware renderer will be owned by SharedRendererState,

+ // after DrawGL is moved to SharedRendererState.

scoped_ptr<HardwareRenderer> hardware_renderer_;

scoped_ptr<AwPdfExporter> pdf_exporter_;

scoped_ptr<PermissionRequestHandler> permission_request_handler_;