Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: android_webview/browser/browser_view_renderer.h

Issue 655813004: Part 1: Refactor Android WebView graphics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor
Patch Set: rewrite, without renames Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/browser_view_renderer.h
diff --git a/android_webview/browser/browser_view_renderer.h b/android_webview/browser/browser_view_renderer.h
index 1fc5650a459c670f963282c545efd7111682d119..59a231fdaf571fa1532fe6fb01a020c148f17b56 100644
--- a/android_webview/browser/browser_view_renderer.h
+++ b/android_webview/browser/browser_view_renderer.h
@@ -61,12 +61,14 @@ class BrowserViewRenderer : public content::SynchronousCompositorClient,
BrowserViewRenderer(
BrowserViewRendererClient* client,
- SharedRendererState* shared_renderer_state,
content::WebContents* web_contents,
const scoped_refptr<base::SingleThreadTaskRunner>& ui_task_runner);
virtual ~BrowserViewRenderer();
+ SharedRendererState* GetSharedRendererState();
+ bool RequestDrawGL(jobject canvas, bool wait_for_completion);
+
// Main handler for view drawing: performs a SW draw immediately, or sets up
// a subsequent GL Draw (via BrowserViewRendererClient::RequestDrawGL) and
// returns true. A false return value indicates nothing was or will be drawn.
@@ -188,7 +190,8 @@ class BrowserViewRenderer : public content::SynchronousCompositorClient,
std::string ToString() const;
BrowserViewRendererClient* client_;
- SharedRendererState* shared_renderer_state_;
+ // BrowserViewRenderer owns SharedRendererState.
boliu 2014/10/24 22:12:01 Don't need this, that's obvious.
hush (inactive) 2014/10/24 22:30:15 Done.
+ SharedRendererState shared_renderer_state_;
content::WebContents* web_contents_;
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
« no previous file with comments | « no previous file | android_webview/browser/browser_view_renderer.cc » ('j') | android_webview/browser/browser_view_renderer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698