Part 1: Refactor Android WebView graphics code

android_webview/browser/browser_view_renderer_proxy.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_PROXY_H_
+#define ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_PROXY_H_
+
+#include "android_webview/browser/parent_compositor_draw_constraints.h"
+#include "base/memory/scoped_ptr.h"
+#include "cc/output/compositor_frame.h"
+#include "cc/resources/returned_resource.h"
+#include "ui/gfx/geometry/vector2d.h"
+
+namespace android_webview {
+
+class BrowserViewRendererProxy {

[boliu, 2014/10/23 16:40:05]

virtual destructor

[hush (inactive), 2014/10/24 21:31:33]

No BrowserViewRendererProxy anymore...

+ public:
+  virtual void SetScrollOffset(gfx::Vector2d scroll_offset) = 0;
+  virtual void SetCompositorFrame(
+      scoped_ptr<cc::CompositorFrame> compositor_frame,
+      bool force_commit) = 0;
+  virtual bool HasCompositorFrame() const = 0;
+  virtual const ParentCompositorDrawConstraints GetParentDrawConstraints()

[boliu, 2014/10/23 16:40:05]

first const is redundant, you are passing by value here

[hush (inactive), 2014/10/24 21:31:33]

Changed this in SRS

+      const = 0;
+  virtual void SwapReturnedResources(cc::ReturnedResourceArray* resources) = 0;
+  virtual void SetForceInvalidateOnNextDrawGL(
+      bool needs_force_invalidate_on_next_draw_gl) = 0;
+  virtual bool NeedsForceInvalidateOnNextDrawGL() const = 0;
+};
+
+}  // namespace android_webview
+
+#endif  // ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_PROXY_H_