Part 1: Refactor Android WebView graphics code

android_webview/browser/aw_gl_methods.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ANDROID_WEBVIEW_BROWSER_AW_GL_METHODS_H_
+#define ANDROID_WEBVIEW_BROWSER_AW_GL_METHODS_H_
+
+#include <jni.h>
+
+namespace android_webview {
+
+/*
+ * An interface that defines GL related methods on the webview.
+ */
+class AwGLMethods {

[boliu, 2014/10/23 16:40:05]

virtual destructor

[hush (inactive), 2014/10/24 21:31:33]

No AwGLMethods anymore in the next patch...

+ public:
+  // Request DrawGL be called. Passing null |canvas| implies the request
+  // will be of AwDrawGLInfo::kModeProcess type. |wait_for_completion|
+  // will cause the call to block until DrawGL has happened; it does not
+  // work when |canvas| is not NULL. The callback may never be made, and
+  // the mode may be promoted to kModeDraw.
+  virtual bool RequestDrawGL(jobject canvas, bool wait_for_completion) = 0;
+
+  // Immediately calls invalidate when the functor is destroyed so that
+  // the destroyed functor is cleared from the displaylist kept by Android.
+  virtual void InvalidateOnFunctorDestroy() = 0;

[boliu, 2014/10/23 16:40:05]

Nothing calls this yet, right? Move it to the follow up patch then

[hush (inactive), 2014/10/24 21:31:33]

No AwGLMethods anymore in the next patch...

+};
+}

[boliu, 2014/10/23 16:40:05]

nit: space above and comment on closing brace

[hush (inactive), 2014/10/24 21:31:33]

No AwGLMethods anymore in the next patch...

+
+#endif  // ANDROID_WEBVIEW_BROWSER_AW_GL_METHODS_H_