Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 655813002: Fix V8's default timer event logger. (Closed)

Created:
6 years, 2 months ago by Yang
Modified:
6 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix V8's default timer event logger. This broke because the optimizing compiler thread no longer holds Isolate::Current() in its TLS. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/counters.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/log.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/log.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M src/log-inl.h View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 2 months ago (2014-10-14 12:58:30 UTC) #1
Jakob Kummerow
lgtm
6 years, 2 months ago (2014-10-14 13:42:12 UTC) #2
Yang
6 years, 2 months ago (2014-10-14 14:45:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24607 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698