Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 655783002: Attempt to fix flaky ChromeOS test timeouts. (Closed)

Created:
6 years, 2 months ago by kustermann
Modified:
6 years, 2 months ago
Reviewers:
orglofch
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, cc-bugs_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Attempt to fix flaky ChromeOS test timeouts. Bisecting the UserAddingScreenTest.ScreenVisibility test timeouts seems to have identified the causing CL. This reverts the causing CL 4c6917e303938f0be7beb244abdfbf4723c2162f -- "cc:: Remove SwapAck throttling from Scheduler." and enables tests again: reverts 497a57a9b9c372cd58e3e1261d79916e4ca247c2 -- "Disable flaky timeout InlineLoginUIBrowserTest.DifferentStorageId on linux" reverts ffc3747adcd49ca0185670dd6bc78078b4721544 -- "Disable WebViewAPITest.AcceptTouchEvents on Linux." reverts efbbf859cec94c1a8d671499d190158fbdce3599 -- "Disabling UserImageManagerTest.SaveUserImageFromProfileImage.". reverts f827c03bbf5971e2f24e32bd90ce4c40f5ee8f1c -- "Disable SharedOptionsTest.ScreenLockPreferencePrimary." reverts 6e402f141ae341c5df18ca81e892089c47fae54f -- "Disable PreferencesTest.MultiProfiles." reverts d65f70589ef04c62678b3e96d674689cbd3fd0c2 -- "Disable NetworkPortalDetectorImplBrowserTest.InSessionDetection." BUG=423332, 423094, 423077, 423053, 423015, 422998, 422868 TBR=orglofch Committed: https://crrev.com/0c972cb5f080fff7b82b86a4445f0faa4393bbc2 Cr-Commit-Position: refs/heads/master@{#299468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -79 lines) Patch
M cc/scheduler/scheduler_state_machine.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 2 chunks +9 lines, -43 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/preferences_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655783002/1
6 years, 2 months ago (2014-10-14 12:53:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 13:06:37 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 13:07:31 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c972cb5f080fff7b82b86a4445f0faa4393bbc2
Cr-Commit-Position: refs/heads/master@{#299468}

Powered by Google App Engine
This is Rietveld 408576698