Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 655763002: Revert of Made top controls work with virtual viewport pinch-to-zoom. (Blink) (Closed)

Created:
6 years, 2 months ago by apavlov
Modified:
6 years, 2 months ago
CC:
blink-reviews, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Made top controls work with virtual viewport pinch-to-zoom. (Blink) (patchset #3 id:100001 of https://codereview.chromium.org/643473002/) Reason for revert: Broke PinchViewportTest.TestTopControlsAdjustment on Mac bots (e.g. see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/32476/steps/webkit_unit_tests/logs/TestTopControlsAdjustment) Original issue's description: > Made top controls work with virtual viewport pinch-to-zoom. (Blink) > > Together with the Chromium-side patch, makes top controls work properly > under the virtual viewport mode of pinch zoom. The key changes on the > Blink side are to adjust both the PinchViewport and FrameView max scroll > bounds to account for the change in the top controls offset on the > compositor. Additionally, I changed these to make the same floating point > and snapping calculations as in the compositor to prevent losing pixel > fractions. > > Chromium side: https://codereview.chromium.org/641873003/ > > BUG=364109 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183639 TBR=aelias@chromium.org,rbyers@chromium.org,bokan@chromium.org NOTREECHECKS=true NOTRY=true BUG=364109 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183653

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -237 lines) Patch
M Source/core/frame/FrameView.cpp View 1 chunk +10 lines, -17 lines 0 comments Download
M Source/core/frame/PinchViewport.h View 3 chunks +1 line, -9 lines 0 comments Download
M Source/core/frame/PinchViewport.cpp View 5 chunks +3 lines, -26 lines 0 comments Download
M Source/web/PageScaleConstraintsSet.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +5 lines, -16 lines 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 4 chunks +11 lines, -159 lines 0 comments Download
M Source/web/tests/data/content-width-1000.html View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
apavlov
Created Revert of Made top controls work with virtual viewport pinch-to-zoom. (Blink)
6 years, 2 months ago (2014-10-14 08:19:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655763002/1
6 years, 2 months ago (2014-10-14 08:22:00 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 08:22:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183653

Powered by Google App Engine
This is Rietveld 408576698