DescriptionRevert of Made top controls work with virtual viewport pinch-to-zoom. (Blink) (patchset #3 id:100001 of https://codereview.chromium.org/643473002/)
Reason for revert:
Broke PinchViewportTest.TestTopControlsAdjustment on Mac bots (e.g. see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/32476/steps/webkit_unit_tests/logs/TestTopControlsAdjustment)
Original issue's description:
> Made top controls work with virtual viewport pinch-to-zoom. (Blink)
>
> Together with the Chromium-side patch, makes top controls work properly
> under the virtual viewport mode of pinch zoom. The key changes on the
> Blink side are to adjust both the PinchViewport and FrameView max scroll
> bounds to account for the change in the top controls offset on the
> compositor. Additionally, I changed these to make the same floating point
> and snapping calculations as in the compositor to prevent losing pixel
> fractions.
>
> Chromium side: https://codereview.chromium.org/641873003/
>
> BUG=364109
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183639
TBR=aelias@chromium.org,rbyers@chromium.org,bokan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=364109
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183653
Patch Set 1 #
Created: 6 years, 2 months ago
(Patch set is too large to download)
Messages
Total messages: 5 (2 generated)
|