Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: Source/core/platform/ScrollView.cpp

Issue 65573002: Remove Scrollbar dependency on AXObjectCache (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/platform/ScrollView.h ('k') | Source/core/platform/ScrollableArea.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "config.h" 26 #include "config.h"
27 #include "core/platform/ScrollView.h" 27 #include "core/platform/ScrollView.h"
28 28
29 #include "core/accessibility/AXObjectCache.h"
30 #include "core/platform/ScrollbarTheme.h" 29 #include "core/platform/ScrollbarTheme.h"
31 #include "core/platform/graphics/GraphicsContextStateSaver.h" 30 #include "core/platform/graphics/GraphicsContextStateSaver.h"
32 #include "core/platform/graphics/GraphicsLayer.h" 31 #include "core/platform/graphics/GraphicsLayer.h"
33 #include "platform/HostWindow.h" 32 #include "platform/HostWindow.h"
34 #include "wtf/StdLibExtras.h" 33 #include "wtf/StdLibExtras.h"
35 34
36 using namespace std; 35 using namespace std;
37 36
38 namespace WebCore { 37 namespace WebCore {
39 38
(...skipping 30 matching lines...) Expand all
70 ASSERT(child->parent() == this); 69 ASSERT(child->parent() == this);
71 child->setParent(0); 70 child->setParent(0);
72 m_children.remove(child); 71 m_children.remove(child);
73 } 72 }
74 73
75 void ScrollView::setHasHorizontalScrollbar(bool hasBar) 74 void ScrollView::setHasHorizontalScrollbar(bool hasBar)
76 { 75 {
77 if (hasBar && !m_horizontalScrollbar) { 76 if (hasBar && !m_horizontalScrollbar) {
78 m_horizontalScrollbar = createScrollbar(HorizontalScrollbar); 77 m_horizontalScrollbar = createScrollbar(HorizontalScrollbar);
79 addChild(m_horizontalScrollbar.get()); 78 addChild(m_horizontalScrollbar.get());
80 didAddHorizontalScrollbar(m_horizontalScrollbar.get()); 79 didAddScrollbar(m_horizontalScrollbar.get(), HorizontalScrollbar);
81 m_horizontalScrollbar->styleChanged(); 80 m_horizontalScrollbar->styleChanged();
82 } else if (!hasBar && m_horizontalScrollbar) { 81 } else if (!hasBar && m_horizontalScrollbar) {
83 willRemoveHorizontalScrollbar(m_horizontalScrollbar.get()); 82 willRemoveScrollbar(m_horizontalScrollbar.get(), HorizontalScrollbar);
84 removeChild(m_horizontalScrollbar.get()); 83 removeChild(m_horizontalScrollbar.get());
85 m_horizontalScrollbar = 0; 84 m_horizontalScrollbar = 0;
86 } 85 }
87
88 if (AXObjectCache* cache = axObjectCache())
89 cache->handleScrollbarUpdate(this);
90 } 86 }
91 87
92 void ScrollView::setHasVerticalScrollbar(bool hasBar) 88 void ScrollView::setHasVerticalScrollbar(bool hasBar)
93 { 89 {
94 if (hasBar && !m_verticalScrollbar) { 90 if (hasBar && !m_verticalScrollbar) {
95 m_verticalScrollbar = createScrollbar(VerticalScrollbar); 91 m_verticalScrollbar = createScrollbar(VerticalScrollbar);
96 addChild(m_verticalScrollbar.get()); 92 addChild(m_verticalScrollbar.get());
97 didAddVerticalScrollbar(m_verticalScrollbar.get()); 93 didAddScrollbar(m_verticalScrollbar.get(), VerticalScrollbar);
98 m_verticalScrollbar->styleChanged(); 94 m_verticalScrollbar->styleChanged();
99 } else if (!hasBar && m_verticalScrollbar) { 95 } else if (!hasBar && m_verticalScrollbar) {
100 willRemoveVerticalScrollbar(m_verticalScrollbar.get()); 96 willRemoveScrollbar(m_verticalScrollbar.get(), VerticalScrollbar);
101 removeChild(m_verticalScrollbar.get()); 97 removeChild(m_verticalScrollbar.get());
102 m_verticalScrollbar = 0; 98 m_verticalScrollbar = 0;
103 } 99 }
104
105 if (AXObjectCache* cache = axObjectCache())
106 cache->handleScrollbarUpdate(this);
107 } 100 }
108 101
109 PassRefPtr<Scrollbar> ScrollView::createScrollbar(ScrollbarOrientation orientati on) 102 PassRefPtr<Scrollbar> ScrollView::createScrollbar(ScrollbarOrientation orientati on)
110 { 103 {
111 return Scrollbar::create(this, orientation, RegularScrollbar); 104 return Scrollbar::create(this, orientation, RegularScrollbar);
112 } 105 }
113 106
114 void ScrollView::setScrollbarModes(ScrollbarMode horizontalMode, ScrollbarMode v erticalMode, 107 void ScrollView::setScrollbarModes(ScrollbarMode horizontalMode, ScrollbarMode v erticalMode,
115 bool horizontalLock, bool verticalLock) 108 bool horizontalLock, bool verticalLock)
116 { 109 {
(...skipping 1027 matching lines...) Expand 10 before | Expand all | Expand 10 after
1144 int ScrollView::pageStep(ScrollbarOrientation orientation) const 1137 int ScrollView::pageStep(ScrollbarOrientation orientation) const
1145 { 1138 {
1146 int length = (orientation == HorizontalScrollbar) ? visibleWidth() : visible Height(); 1139 int length = (orientation == HorizontalScrollbar) ? visibleWidth() : visible Height();
1147 int minPageStep = static_cast<float>(length) * minFractionToStepWhenPaging() ; 1140 int minPageStep = static_cast<float>(length) * minFractionToStepWhenPaging() ;
1148 int pageStep = std::max(minPageStep, length - maxOverlapBetweenPages()); 1141 int pageStep = std::max(minPageStep, length - maxOverlapBetweenPages());
1149 1142
1150 return std::max(pageStep, 1); 1143 return std::max(pageStep, 1);
1151 } 1144 }
1152 1145
1153 } // namespace WebCore 1146 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/platform/ScrollView.h ('k') | Source/core/platform/ScrollableArea.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698