Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 65573002: Remove Scrollbar dependency on AXObjectCache (Closed)

Created:
7 years, 1 month ago by rwlbuis
Modified:
7 years, 1 month ago
CC:
blink-reviews, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove Scrollbar dependency on AXObjectCache Move AXObjectCache usage from platform files to FrameView. Based on https://bugs.webkit.org/show_bug.cgi?id=114514 BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161570

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -63 lines) Patch
M Source/core/frame/FrameView.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/platform/ScrollView.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/platform/ScrollView.cpp View 3 chunks +4 lines, -11 lines 0 comments Download
M Source/core/platform/ScrollableArea.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/platform/ScrollableArea.cpp View 1 chunk +10 lines, -17 lines 0 comments Download
M Source/core/platform/Scrollbar.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/platform/Scrollbar.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 2 chunks +4 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderListBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/ScrollbarGroup.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rwlbuis
Move dependency removal.
7 years, 1 month ago (2013-11-07 22:02:09 UTC) #1
abarth-chromium
lgtm
7 years, 1 month ago (2013-11-07 22:07:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/65573002/1
7 years, 1 month ago (2013-11-07 22:10:05 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-08 00:15:36 UTC) #4
Message was sent while issue was closed.
Change committed as 161570

Powered by Google App Engine
This is Rietveld 408576698