Added integration tests for falling back from the HTTP proxy to direct.

Added integration tests for falling back from the HTTP proxy to direct.

Also did some miscellaneous cleanup of chrome_proxy_metrics.py.

BUG=374409
Committed: https://crrev.com/1ce3a4b7cc1ab5217287f658bbf6cccb0ef5404c
Cr-Commit-Position: refs/heads/master@{#299582}

[sclittle, 2014-10-14 02:10:48]

sclittle@chromium.org changed reviewers:
+ bengr@chromium.org, bolian@chromium.org

[sclittle, 2014-10-14 02:10:49]

bengr: all
bolian: chrome_proxy_metrics.js

Thanks in advance!

[bolian, 2014-10-14 06:00:49]

https://codereview.chromium.org/655703002/diff/1/tools/chrome_proxy/integrati...
File tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py (right):

https://codereview.chromium.org/655703002/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py:277:
self._metrics.VerifyProxyInfo(tab, proxies, bad_proxies)
Why there is bad proxy already before navigation?

https://codereview.chromium.org/655703002/diff/1/tools/chrome_proxy/integrati...
File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right):

https://codereview.chromium.org/655703002/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:174: """ Returns
True if all configured proxies are bypassed."""
Can you update the doc to reflect the 2nd return value?

https://codereview.chromium.org/655703002/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:236: _,
expected_bad_proxies = self.IsProxyBypassed(tab)
I think you want to verify the first return value is True?

[bengr, 2014-10-14 16:34:41]

https://codereview.chromium.org/655703002/diff/1/tools/chrome_proxy/integrati...
File
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/http_to_direct_fallback.py
(right):

https://codereview.chromium.org/655703002/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/http_to_direct_fallback.py:10:

Comment?

https://codereview.chromium.org/655703002/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/http_to_direct_fallback.py:16:

remove blank line

[sclittle, 2014-10-14 17:26:50]

Patchset #2 (id:20001) has been deleted

[sclittle, 2014-10-14 17:36:45]

https://codereview.chromium.org/655703002/diff/1/tools/chrome_proxy/integrati...
File tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py (right):

https://codereview.chromium.org/655703002/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py:277:
self._metrics.VerifyProxyInfo(tab, proxies, bad_proxies)
On 2014/10/14 06:00:49, bolian wrote:
> Why there is bad proxy already before navigation?

Added a comment.

In order to have the test run starting from the HTTP fallback proxy, the startup
URL for the page test is http://check.googlezip.net/fallback. So when Chrome is
started for the test, it's loaded with this fallback URL, then when that page
has fully loaded, it begins the test.

This check here is to verify that this is true before beginning the test proper.

https://codereview.chromium.org/655703002/diff/1/tools/chrome_proxy/integrati...
File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right):

https://codereview.chromium.org/655703002/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:174: """ Returns
True if all configured proxies are bypassed."""
On 2014/10/14 06:00:49, bolian wrote:
> Can you update the doc to reflect the 2nd return value?

Done.

https://codereview.chromium.org/655703002/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:236: _,
expected_bad_proxies = self.IsProxyBypassed(tab)
On 2014/10/14 06:00:49, bolian wrote:
> I think you want to verify the first return value is True?

Done.

https://codereview.chromium.org/655703002/diff/1/tools/chrome_proxy/integrati...
File
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/http_to_direct_fallback.py
(right):

https://codereview.chromium.org/655703002/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/http_to_direct_fallback.py:10:

On 2014/10/14 16:34:41, bengr1 wrote:
> Comment?

Done.

https://codereview.chromium.org/655703002/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/http_to_direct_fallback.py:16:

On 2014/10/14 16:34:41, bengr1 wrote:
> remove blank line

Done.

[bolian, 2014-10-14 18:07:42]

lgtm

[bengr, 2014-10-14 22:22:24]

lgtm

[sclittle, 2014-10-14 22:22:45]

The CQ bit was checked by sclittle@chromium.org

[commit-bot: I haz the power, 2014-10-14 22:25:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/655703002/40001

[commit-bot: I haz the power, 2014-10-14 23:19:34]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2014-10-14 23:20:43]

Patchset 2 (id:??) landed as
https://crrev.com/1ce3a4b7cc1ab5217287f658bbf6cccb0ef5404c
Cr-Commit-Position: refs/heads/master@{#299582}