Issue 655633003: Revert of add ganesh checkbox to skfiddle interface

Issue 655633003: Revert of add ganesh checkbox to skfiddle interface (Closed)

Created:
6 years, 2 months ago by humper

Modified:
6 years, 2 months ago

Reviewers:
tfarina, jcgregorio, mtklein

CC:
reviews_skia.org, mtklein

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of add ganesh checkbox to skfiddle interface (patchset #6 id:270001 of https://codereview.chromium.org/649313002/) Reason for revert: adding -Dskia_mesa=1 broke production; don't yet know why and don't want to leave things in a broken state. Original issue's description: > add ganesh checkbox to skfiddle interface > > BUG=skia: > R=mtklein@google.com, tfarina@chromium.org > > Committed: https://skia.googlesource.com/skia/+/ccb54895c614632fd01d22b64ab614921f980eb1 TBR=tfarina@chromium.org,jcgregorio@google.com,mtklein@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/67f2d3c5147c0c71596acb4d5059e4933f7fca88

Created: 6 years, 2 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -80 lines)			Patch
M	experimental/webtry/main.cpp	View	4 chunks	+2 lines, -20 lines	0 comments	Download
M	experimental/webtry/res/js/webtry.js	View	3 chunks	+1 line, -10 lines	0 comments	Download
M	experimental/webtry/scripts/fiddle_gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	experimental/webtry/setup/continue_install_jail.sh	View	1 chunk	+1 line, -1 line	0 comments	Download
M	experimental/webtry/setup/setup_jail.sh	View	1 chunk	+1 line, -1 line	0 comments	Download
M	experimental/webtry/templates/sidebar.html	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	experimental/webtry/templates/template.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	experimental/webtry/webtry.go	View	16 chunks	+23 lines, -40 lines	0 comments	Download

Total messages: 6 (2 generated)

humper

Created Revert of add ganesh checkbox to skfiddle interface

6 years, 2 months ago (2014-10-13 23:02:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655633003/1

6 years, 2 months ago (2014-10-13 23:04:52 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-13 23:05:13 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 67f2d3c5147c0c71596acb4d5059e4933f7fca88