Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 655613002: Add pak files to the isolate. (Closed)

Created:
6 years, 2 months ago by Avi (use Gerrit)
Modified:
6 years, 2 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add pak files to the isolate. BUG=410411 TEST=no visible change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183631

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : split three ways #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/web/WebKitUnitTests.isolate View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/web/web_tests.gyp View 1 2 1 chunk +1 line, -0 lines 3 comments Download

Messages

Total messages: 8 (2 generated)
Avi (use Gerrit)
Nate... So I'm trying to ensure that loading a bogus pak file crashes (https://codereview.chromium.org/537063002/). But ...
6 years, 2 months ago (2014-10-13 22:14:55 UTC) #2
Nate Chapin
https://codereview.chromium.org/655613002/diff/190001/Source/web/web_tests.gyp File Source/web/web_tests.gyp (right): https://codereview.chromium.org/655613002/diff/190001/Source/web/web_tests.gyp#newcode142 Source/web/web_tests.gyp:142: '<(DEPTH)/content/content_shell_and_tests.gyp:content_shell_pak', It's counter-intuitive that webkit_unit_tests requires content_shell, given that ...
6 years, 2 months ago (2014-10-13 22:22:33 UTC) #3
Avi (use Gerrit)
Welcome to dependency hell. https://codereview.chromium.org/655613002/diff/190001/Source/web/web_tests.gyp File Source/web/web_tests.gyp (right): https://codereview.chromium.org/655613002/diff/190001/Source/web/web_tests.gyp#newcode142 Source/web/web_tests.gyp:142: '<(DEPTH)/content/content_shell_and_tests.gyp:content_shell_pak', On 2014/10/13 22:22:33, Nate ...
6 years, 2 months ago (2014-10-13 22:27:38 UTC) #4
Nate Chapin
lgtm https://codereview.chromium.org/655613002/diff/190001/Source/web/web_tests.gyp File Source/web/web_tests.gyp (right): https://codereview.chromium.org/655613002/diff/190001/Source/web/web_tests.gyp#newcode142 Source/web/web_tests.gyp:142: '<(DEPTH)/content/content_shell_and_tests.gyp:content_shell_pak', On 2014/10/13 22:27:37, Avi wrote: > On ...
6 years, 2 months ago (2014-10-13 22:29:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655613002/190001
6 years, 2 months ago (2014-10-13 22:32:40 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 00:04:28 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:190001) as 183631

Powered by Google App Engine
This is Rietveld 408576698