Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 655603003: Reland: Remove "needkey" event and add its replacement, "encrypted". (Closed)

Created:
6 years, 2 months ago by sandersd (OOO until July 31)
Modified:
6 years, 2 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, dglazkov+blink, philipj_slow, eric.carlson_apple.com, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Reland: Remove "needkey" event and add its replacement, "encrypted". This new event is of type MediaEncryptedEvent, which has initDataType instead of contentType (but this CL just renames one to the other, without translation), and changes the type of initData from Uint8Array to ArrayBuffer as per the WD EME spec. Also in this CL: - Start renaming keyNeeded() to encrypted() by renaming the it on HTMLMediaElementEncryptedMedia. - Remove unused contentType argument from createWebkitNeedKeyEvent() (good thing it's unused or the contentType to initDataType change would be a lot harder). - Fix prefixed/encrypted-media-events.html test to test the prefixed needkey event instead of the unprefixed one. TBR=jochen@chromium.org,ddorwin@chromium.org BUG=224786 (cherry picked from commit ad09c3ed1914691ee4a089cfe95988892ed42407) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -318 lines) Patch
M LayoutTests/media/encrypted-media/encrypted-media-lifetime-reload.html View 3 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/media/encrypted-media/encrypted-media-lifetime-reload-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
D LayoutTests/media/encrypted-media/encrypted-media-needkey.html View 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/media/encrypted-media/encrypted-media-needkey-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
A + LayoutTests/media/encrypted-media/encrypted-media-onencrypted.html View 3 chunks +9 lines, -8 lines 0 comments Download
A LayoutTests/media/encrypted-media/encrypted-media-onencrypted-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/media/encrypted-media/encrypted-media-playback-multiple-sessions.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/media/encrypted-media/encrypted-media-playback-multiple-sessions-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/media/encrypted-media/encrypted-media-playback-setmediakeys-after-src.html View 3 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/media/encrypted-media/encrypted-media-playback-setmediakeys-after-src-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/media/encrypted-media/encrypted-media-playback-setmediakeys-before-src.html View 3 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/media/encrypted-media/encrypted-media-playback-setmediakeys-before-src-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/media/encrypted-media/encrypted-media-v2-syntax.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/encrypted-media/encrypted-media-waiting-for-a-key.html View 3 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/media/encrypted-media/encrypted-media-waiting-for-a-key-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/media/encrypted-media/prefixed/encrypted-media-events.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/media/encrypted-media/prefixed/encrypted-media-events-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/EventTypeNames.in View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp View 3 chunks +14 lines, -12 lines 0 comments Download
M Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.idl View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/encryptedmedia/MediaEncryptedEvent.h View 1 chunk +20 lines, -20 lines 0 comments Download
A + Source/modules/encryptedmedia/MediaEncryptedEvent.cpp View 1 chunk +9 lines, -11 lines 0 comments Download
A + Source/modules/encryptedmedia/MediaEncryptedEvent.idl View 1 chunk +3 lines, -3 lines 0 comments Download
D Source/modules/encryptedmedia/MediaKeyNeededEvent.h View 1 chunk +0 lines, -73 lines 0 comments Download
D Source/modules/encryptedmedia/MediaKeyNeededEvent.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
D Source/modules/encryptedmedia/MediaKeyNeededEvent.idl View 1 chunk +0 lines, -33 lines 0 comments Download
M Source/modules/modules.gypi View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M public/platform/WebMediaPlayerClient.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sandersd (OOO until July 31)
The failing tests should be fixed by https://chromium.googlesource.com/chromium/src/+/8163d134ca19f57024ff96a3a4522ce1489ceee7.
6 years, 2 months ago (2014-10-13 20:02:30 UTC) #1
ddorwin
rs LGTM of re-land
6 years, 2 months ago (2014-10-13 20:04:12 UTC) #3
sandersd (OOO until July 31)
6 years, 2 months ago (2014-10-13 20:05:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655603003/1
6 years, 2 months ago (2014-10-13 20:06:42 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 22:37:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183628

Powered by Google App Engine
This is Rietveld 408576698