Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 655573002: Fix race in supports_simd(). (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix race in supports_simd(). Local statics are not thread safe in Chrome. Use an SkLazyPtr instead. See https://code.google.com/p/chromium/issues/detail?id=418041 BUG=418041 Committed: https://skia.googlesource.com/skia/+/c09e2af17fab03d3d36c20e5201a560c3e4c233e

Patch Set 1 #

Patch Set 2 : external linkage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M src/opts/opts_check_x86.cpp View 1 3 chunks +17 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655573002/1
6 years, 2 months ago (2014-10-13 14:28:48 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-13 14:28:49 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/17)
6 years, 2 months ago (2014-10-13 14:30:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655573002/130001
6 years, 2 months ago (2014-10-13 14:34:50 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-13 14:34:50 UTC) #8
mtklein
6 years, 2 months ago (2014-10-13 14:38:09 UTC) #10
bungeman-skia
lgtm
6 years, 2 months ago (2014-10-13 14:59:01 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 19:48:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:130001) as c09e2af17fab03d3d36c20e5201a560c3e4c233e

Powered by Google App Engine
This is Rietveld 408576698