Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 655563005: Subzero: Enhance the timer dump format. (Closed)

Created:
6 years, 2 months ago by Jim Stichnoth
Modified:
6 years, 2 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Enhance the timer dump format. This adds update counts to the output, e.g.: Total across all functions - Flat times: 0.262297 (13.0%): [ 1287] linearScan 0.243965 (12.1%): [ 1287] emit ... This is useful to know when some passes are called once per function and others are called several times per function. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=abce6e568a7d72e9b82f767e866cc19dd851d476

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reset UpdateCount as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -9 lines) Patch
M src/IceTimerTree.h View 3 chunks +4 lines, -2 lines 0 comments Download
M src/IceTimerTree.cpp View 1 7 chunks +51 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
6 years, 2 months ago (2014-10-14 15:14:16 UTC) #2
jvoung (off chromium)
lgtm https://codereview.chromium.org/655563005/diff/1/src/IceTimerTree.cpp File src/IceTimerTree.cpp (right): https://codereview.chromium.org/655563005/diff/1/src/IceTimerTree.cpp#newcode119 src/IceTimerTree.cpp:119: Node.Time = 0; Node.UpdateCount = 0 also?
6 years, 2 months ago (2014-10-14 17:25:50 UTC) #3
Jim Stichnoth
Committed patchset #2 (id:20001) manually as abce6e568a7d72e9b82f767e866cc19dd851d476 (presubmit successful).
6 years, 2 months ago (2014-10-14 18:09:38 UTC) #4
Jim Stichnoth
6 years, 2 months ago (2014-10-14 18:10:09 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/655563005/diff/1/src/IceTimerTree.cpp
File src/IceTimerTree.cpp (right):

https://codereview.chromium.org/655563005/diff/1/src/IceTimerTree.cpp#newcode119
src/IceTimerTree.cpp:119: Node.Time = 0;
On 2014/10/14 17:25:50, jvoung wrote:
> Node.UpdateCount = 0 also?

Oops, done.

Powered by Google App Engine
This is Rietveld 408576698