Added support of shared_library build for tests

Added support of shared_library build for tests
breakpad_unittests and sandbox_linux_unittests

R=thestig@chromium.org, jbudorick@chromium.org, jorgelo@chromium.org
BUG=344868
TEST=Turn on components build (component=shared_library) ensure that
breakpad_unittests and sandbox_linux_unittests are starting
(breakpad_unittests_deps and sandbox_linux_unittests_deps targets
correspondingly)

Committed: https://crrev.com/5ffbc9ec423da21f2df1ff73aa524eb78eb2eb7b
Cr-Commit-Position: refs/heads/master@{#301797}

[ripp, 2014-10-22 07:51:18]

Fixed failure of several breakpad tests tests

[Lei Zhang, 2014-10-22 18:59:18]

thestig@chromium.org changed reviewers:
+ cjhopman@chromium.org

[Lei Zhang, 2014-10-22 18:59:18]

breakpad lgtm in that it's consistent with sandbox/linux/sandbox_linux.gypi.

+cjhopman who might be able to help review this.

[jln (very slow on Chromium), 2014-10-22 19:10:25]

jln@chromium.org changed reviewers:
+ jln@chromium.org

[jln (very slow on Chromium), 2014-10-22 19:10:26]

sandbox/linux/sandbox_linux.gypi lgtm with nit.

But if someone with better GYP knowledge wants to chime-in, please do.

Shouldn't we also fix the .gn files?

https://codereview.chromium.org/655543005/diff/20001/sandbox/linux/sandbox_li...
File sandbox/linux/sandbox_linux.gypi (right):

https://codereview.chromium.org/655543005/diff/20001/sandbox/linux/sandbox_li...
sandbox/linux/sandbox_linux.gypi:320: # For the component build, ensure
dependent shared libraries are stripped
Nit: line wrap

[cjhopman, 2014-10-22 19:21:49]

Can you build these as apks instead? (iirc, the sandbox ones don't work as an
apk, but the breakpad ones might)

See base_unittests_apk for an example. If you can do that, the shared libraries
will all be bundled correctly as expected.

For non-apk component unittests this looks like the right approach.

https://codereview.chromium.org/655543005/diff/20001/breakpad/breakpad.gyp
File breakpad/breakpad.gyp (right):

https://codereview.chromium.org/655543005/diff/20001/breakpad/breakpad.gyp#ne...
breakpad/breakpad.gyp:908: # and put alongside forwarder to simplify pushing to
the device.
s/forwarder/breakpad

https://codereview.chromium.org/655543005/diff/20001/sandbox/linux/sandbox_li...
File sandbox/linux/sandbox_linux.gypi (right):

https://codereview.chromium.org/655543005/diff/20001/sandbox/linux/sandbox_li...
sandbox/linux/sandbox_linux.gypi:321: # and put alongside forwarder to simplify
pushing to the device.
s/forwarder/sandbox_linux_unittests (or some such)

[ripp, 2014-10-23 05:21:54]

On 2014/10/22 19:21:49, cjhopman wrote:
> Can you build these as apks instead? (iirc, the sandbox ones don't work as an
> apk, but the breakpad ones might)
> 
> See base_unittests_apk for an example. If you can do that, the shared
libraries
> will all be bundled correctly as expected.
> 

Yes, as far as I understand sandbox must not be build as an APK
(crbug.com/169416)
And I already tried to build breakpad as APK, but without much success: in the
test, at least, the path to the temporary directory is hardcoded
(/data/local/tmp), and APK process does not have access rights to it. I suspect
that you will find still some other problems related to the fact that the test
is designed to run as a normal executable, and this will lead to a significant
change in the code of the test itself.
Another approach which I tried, was to replace by GYP libstlport_shared to
libstlport_static. This is enough to ensure that the executable can be started
and works even in the components build.

Is there real necessity to build breakpad as an APK?

[ripp, 2014-10-23 06:17:51]

https://codereview.chromium.org/655543005/diff/20001/breakpad/breakpad.gyp
File breakpad/breakpad.gyp (right):

https://codereview.chromium.org/655543005/diff/20001/breakpad/breakpad.gyp#ne...
breakpad/breakpad.gyp:908: # and put alongside forwarder to simplify pushing to
the device.
On 2014/10/22 19:21:48, cjhopman wrote:
> s/forwarder/breakpad

Done.

https://codereview.chromium.org/655543005/diff/20001/sandbox/linux/sandbox_li...
File sandbox/linux/sandbox_linux.gypi (right):

https://codereview.chromium.org/655543005/diff/20001/sandbox/linux/sandbox_li...
sandbox/linux/sandbox_linux.gypi:320: # For the component build, ensure
dependent shared libraries are stripped
On 2014/10/22 19:10:26, jln wrote:
> Nit: line wrap

Done.

https://codereview.chromium.org/655543005/diff/20001/sandbox/linux/sandbox_li...
sandbox/linux/sandbox_linux.gypi:321: # and put alongside forwarder to simplify
pushing to the device.
On 2014/10/22 19:21:49, cjhopman wrote:
> s/forwarder/sandbox_linux_unittests (or some such)

Done.

[jln (very slow on Chromium), 2014-10-24 00:07:17]

jln@chromium.org changed reviewers:
+ rsesek@chromium.org

[jln (very slow on Chromium), 2014-10-24 00:08:31]

> Is there real necessity to build breakpad as an APK?

Lei or Rsesek should comment, but I suspect that breakpad can't be built as an
APK because it also relies on starting mono-threaded (which APKs don't allow you
to do), or perhaps some other low-level requirement.

[ripp, 2014-10-28 10:53:39]

On 2014/10/24 00:08:31, jln (OOO til 29th) wrote:
> > Is there real necessity to build breakpad as an APK?
> 
> Lei or Rsesek should comment, but I suspect that breakpad can't be built as an
> APK because it also relies on starting mono-threaded (which APKs don't allow
you
> to do), or perhaps some other low-level requirement.

I agree, that breakpad should be left as non-APK.


cjhopman, can you please approve that it is ok?

[cjhopman, 2014-10-28 16:28:32]

On 2014/10/28 10:53:39, ripp wrote:
> On 2014/10/24 00:08:31, jln (OOO til 29th) wrote:
> > > Is there real necessity to build breakpad as an APK?
> > 
> > Lei or Rsesek should comment, but I suspect that breakpad can't be built as
an
> > APK because it also relies on starting mono-threaded (which APKs don't allow
> you
> > to do), or perhaps some other low-level requirement.
> 
> I agree, that breakpad should be left as non-APK.
> 
> 
> cjhopman, can you please approve that it is ok?

lgtm. I think breakpad_unittests probably could be built as an apk (I don't
think it does anything that wouldn't work there), but there isn't really much
gain if we have to support non-apk based test suites for sandbox_linux (I don't
know these tests enough to say that they could or could not be an apk) anyway.

[ripp, 2014-10-29 05:41:35]

The CQ bit was checked by ripp@yandex-team.ru

[commit-bot: I haz the power, 2014-10-29 05:42:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/655543005/40001

[commit-bot: I haz the power, 2014-10-29 06:40:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-29 06:41:19]

Patchset 3 (id:??) landed as
https://crrev.com/5ffbc9ec423da21f2df1ff73aa524eb78eb2eb7b
Cr-Commit-Position: refs/heads/master@{#301797}