Issue 655543003: remove the FINAL macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 655543003: remove the FINAL macro (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore

Modified:
6 years, 2 months ago

Reviewers:
danakj, dcheng

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

remove the FINAL macro All uses of the FINAL macro have been removed now, let's remove the macro itself. BUG=417463 Committed: https://crrev.com/b6e8e6c86aa003c5bf04ad26a937733c2e9f8591 Cr-Commit-Position: refs/heads/master@{#299523}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	base/compiler_specific.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 7 (2 generated)

Mostyn Bramley-Moore

@danakj: I think we can remove the FINAL macro now.

6 years, 2 months ago (2014-10-13 12:15:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655543003/1

6 years, 2 months ago (2014-10-14 17:38:20 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-14 19:25:12 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b6e8e6c86aa003c5bf04ad26a937733c2e9f8591
Cr-Commit-Position: refs/heads/master@{#299523}